Conversation
Closes SRC-1356. Test plan: Review.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
bobheadxi
reviewed
Aug 14, 2025
bobheadxi
approved these changes
Aug 14, 2025
pjlast
approved these changes
Aug 15, 2025
unknwon
approved these changes
Aug 15, 2025
|
|
||
| <Accordion title="Authorization Code Flow (Private Clients)"> | ||
|
|
||
| 1. **Authorization Request**: Redirect users to Sourcegraph's authorization endpoint: |
Contributor
There was a problem hiding this comment.
nit
Suggested change
| 1. **Authorization Request**: Redirect users to Sourcegraph's authorization endpoint: | |
| 1. **Authorization Request**: Redirect users to Sourcegraph's authorization endpoint (line breaks for better illustration): |
Member
Author
There was a problem hiding this comment.
Do you think someone who we want to trust to implement OAuth correctly will not understand that? 😬
|
|
||
| The user may be asked for consent to grant your app the requested scopes if not previously granted. | ||
|
|
||
| 2. **Authorization Response**: Sourcegraph redirects back with an authorization code and the state parameter: |
Contributor
There was a problem hiding this comment.
nit
Suggested change
| 2. **Authorization Response**: Sourcegraph redirects back with an authorization code and the state parameter: | |
| 2. **Authorization Response**: Sourcegraph redirects back with an authorization code and the state parameter (line breaks for better illustration): |
Co-authored-by: ᴊᴏᴇ ᴄʜᴇɴ <jc@unknwon.io>
Co-authored-by: ᴊᴏᴇ ᴄʜᴇɴ <jc@unknwon.io>
Co-authored-by: ᴊᴏᴇ ᴄʜᴇɴ <jc@unknwon.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes SRC-1356.
Test plan: Review.