Skip to content

feat: update docs for commit signing#1021

Merged
MaedahBatool merged 5 commits intosg-next-apr-2025from
bahrmichael/commit-signing
Mar 25, 2025
Merged

feat: update docs for commit signing#1021
MaedahBatool merged 5 commits intosg-next-apr-2025from
bahrmichael/commit-signing

Conversation

@bahrmichael
Copy link
Copy Markdown
Contributor

@bahrmichael bahrmichael commented Mar 10, 2025 •
edited
Loading

Closes SRCH-1746

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 10, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sourcegraph-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 25, 2025 8:12pm

derek-feriancek-sg
derek-feriancek-sg reviewed Mar 11, 2025
View reviewed changes
docs/admin/config/batch_changes.mdx Outdated

### Commit signing with SSH Keys (GitLab and GitHub)

<Callout type="note"> This feature is supported only in Sourcegraph versions 6.2 or more.</Callout>
Copy link
Copy Markdown
Contributor

@derek-feriancek-sg derek-feriancek-sg Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: How about "or later" instead of "or more"?

Copy link
Copy Markdown
Contributor

@derek-feriancek-sg derek-feriancek-sg Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, after finishing reading this diff I see we have "or more" in other parts of the docs as well. I'm curious what Maedah's stance is

Copy link
Copy Markdown
Contributor Author

@bahrmichael bahrmichael Mar 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MaedahBatool do we have a standard here?

Copy link
Copy Markdown
Contributor

@MaedahBatool MaedahBatool Mar 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @bahrmichael we have the following formats:

  • v6.2 or more
  • v6.2+

@bahrmichael
Copy link
Copy Markdown
Contributor Author

bahrmichael commented Mar 13, 2025

@MaedahBatool This PR is now ready for review. The feature will be available to customers with the 6.2 release. Should we target main, or a different branch?

@bahrmichael bahrmichael marked this pull request as ready for review March 13, 2025 11:15
LeweyM
LeweyM reviewed Mar 18, 2025
View reviewed changes
MaedahBatool
MaedahBatool approved these changes Mar 25, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@MaedahBatool MaedahBatool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added few changes via direct commits. Approving now looks good :)

@MaedahBatool MaedahBatool changed the base branch from main to sg-next-apr-2025 March 25, 2025 20:10
@MaedahBatool MaedahBatool merged commit 59866d0 into sg-next-apr-2025 Mar 25, 2025
7 checks passed
@MaedahBatool MaedahBatool deleted the bahrmichael/commit-signing branch March 25, 2025 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LeweyM LeweyM LeweyM left review comments

+2 more reviewers

@derek-feriancek-sg derek-feriancek-sg derek-feriancek-sg left review comments

@MaedahBatool MaedahBatool MaedahBatool approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bahrmichael @MaedahBatool @LeweyM @derek-feriancek-sg