Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cache): complete refactor for more flexibility #2156

Merged
merged 4 commits into from
Aug 14, 2024

Conversation

akshatdubeysf
Copy link
Contributor

BREAKING CHANGE:
different decorator syntax for repository level, different config keys, different bindings

Description

  • Added decorators for easy caching implemention in any TS Class
  • Updated repository mixins to use these decorators for DRY
  • Added relevant tests
  • Updated documentation for the new implementation and usage.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Intermediate change (work in progress)

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Any dependent changes have been merged and published in downstream modules

@akshatdubeysf akshatdubeysf requested review from samarpan-b and a team as code owners August 14, 2024 12:27
Copy link

sonarcloud bot commented Aug 14, 2024

@yeshamavani yeshamavani merged commit d0e0233 into master Aug 14, 2024
5 checks passed
@yeshamavani yeshamavani deleted the caching-extension branch August 14, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants