Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(file-utils): add a utility package for handling file uploads #2155

Merged
merged 2 commits into from
Aug 14, 2024
Merged

feat(file-utils): add a utility package for handling file uploads #2155

merged 2 commits into from
Aug 14, 2024

Conversation

akshatdubeysf
Copy link
Contributor

Description

  • added a package for convenient uploading of files and multipart requests in general
  • added relevant tests
  • update documentation

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Intermediate change (work in progress)

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Any dependent changes have been merged and published in downstream modules

@akshatdubeysf akshatdubeysf requested a review from a team as a code owner August 14, 2024 08:45
samarpanB
samarpanB reviewed Aug 14, 2024
View reviewed changes
packages/file-utils/package.json Outdated
{
"name": "@sourceloop/file-utils",
"version": "0.0.0",
"description": "A Tenant guard extension to prevent cross tenant access and operations",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

samarpanB
samarpanB reviewed Aug 14, 2024
View reviewed changes
packages/file-utils/README.md Outdated
To install the package, run the following command:

```shell
npm install @loopback/file-utils
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@yeshamavani yeshamavani merged commit 1ce6787 into master Aug 14, 2024
5 checks passed
@yeshamavani yeshamavani deleted the file-utils branch August 14, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samarpanB samarpanB samarpanB left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akshatdubeysf @samarpanB @yeshamavani