Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): add support for jenkinsfile template in sl scaffold #2152

Merged
merged 4 commits into from
Aug 14, 2024

Conversation

Surbhi-sharma1
Copy link
Contributor

@Surbhi-sharma1 Surbhi-sharma1 commented Aug 12, 2024

add support for jenkinsfile template in sl scaffold

GH-2149

Description

add support for jenkinsfile template in sl scaffold

Fixes #2149

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Intermediate change (work in progress)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Any dependent changes have been merged and published in downstream modules

add support for jenkinsfile template in sl scaffold

GH-2149
@Surbhi-sharma1 Surbhi-sharma1 requested a review from a team as a code owner August 12, 2024 08:19
@Surbhi-sharma1 Surbhi-sharma1 marked this pull request as draft August 12, 2024 08:21
@Surbhi-sharma1 Surbhi-sharma1 marked this pull request as ready for review August 12, 2024 09:17
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this added to base command and not the scaffold command file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was getting issue with helmprompt option that needs to be prompted while adding this in scaffold file .

Copy link

sonarcloud bot commented Aug 14, 2024

@yeshamavani yeshamavani merged commit 8100aa7 into master Aug 14, 2024
5 checks passed
@yeshamavani yeshamavani deleted the GH-2149-3 branch August 14, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@sourceloop/cli:add updated eslintrc.js file and template support for jenkins
2 participants