Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(feature-toggle): changes to make it more generic #2142

Merged
merged 2 commits into from
Aug 1, 2024
Merged

Conversation

yeshamavani
Copy link
Contributor

MIGRATION CHANGE:
migration-20231222053654- changed table name
migration-20210913104858- changed table name
migration-20230612141912- table name chnaged

BREAKING CHANGE:
db schema changes

gh-2141

Description

Changed the name of feature_toggle to feature_values
changed the db schema

Fixes #2141

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Intermediate change (work in progress)

How Has This Been Tested?

Executed the APIs to test this.

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Any dependent changes have been merged and published in downstream modules

MIGRATION CHANGE:
migration-20231222053654- changed table name
migration-20210913104858- changed table name
migration-20230612141912- table name chnaged

BREAKING CHANGE:
db schema changes

gh-2141
@yeshamavani yeshamavani requested a review from a team as a code owner August 1, 2024 10:46
Copy link

sonarcloud bot commented Aug 1, 2024

Copy link
Contributor

@shubhamp-sf shubhamp-sf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@a-ganguly a-ganguly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to make it more generic

@a-ganguly a-ganguly merged commit abb415a into master Aug 1, 2024
5 checks passed
@a-ganguly a-ganguly deleted the GH-2141 branch August 1, 2024 13:39
Copy link

@a-ganguly a-ganguly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to make it more generic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@sourceloop/feature-toggle-service: modify for saas specific apps
3 participants