fix(payment-service): fix issues in payment service #2139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeshamavani
requested changes
Jul 31, 2024
services/payment-service/README.md
Outdated
There was a problem hiding this comment.
Can you mention in the README the order in which the APIs will be invoked for end to end complete payment transaction.
| @@ -110,7 +110,7 @@ export class PaymentServiceComponent implements Component { | |||
| Binding.bind(PayPalBindings.PayPalHelper.key).to(null), | |||
| ]; | |||
| this.application.component(CoreComponent); | |||
|
|
|||
| this.application.component(TenantUtilitiesComponent); | |||
There was a problem hiding this comment.
It was giving tenant guard Service related errors.
Comment on lines
+96
to
+104
| @authenticate(STRATEGY.BEARER) | ||
| @authorize({ | ||
| permissions: [ | ||
| PermissionKey.UpdateTransaction, | ||
| PermissionKey.UpdateTransactionNum, | ||
| ], | ||
| }) |
There was a problem hiding this comment.
is this PR marked as breaking change
Surbhi-sharma1
force-pushed
the
GH-2138
branch
from
bc7831b
to
d815228
Compare
MIGRATION CHANGE: migration-20210722063857- fix migration GH-2138
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix issues in payment service
GH-2138
Description
Fixes #2138
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: