feat(entity-archival): add package for entity level archival #2137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
samarpan-b
reviewed
Aug 26, 2024
| private options: ArchivalComponentOptions = DEFAULT_ARCHIVAL_OPTIONS, | ||
| ) { | ||
| this.providers = {}; | ||
| this.application.component(CoreComponent); |
There was a problem hiding this comment.
why do we have this dependency ?
samarpan-b
requested changes
Aug 26, 2024
|
|
||
| ## Overview | ||
|
|
||
| `@sourceloop/entity-archival` package is a powerful LoopBack 4 extension designed to seamlessly |
There was a problem hiding this comment.
after reading this, I feel this should be part of soft delete package
samarpan-b
reviewed
Aug 26, 2024
| name: 'filter_inquired', | ||
| type: 'object', | ||
| }) | ||
| filterInquired: Object; |
There was a problem hiding this comment.
just keep name as filter
samarpan-b
reviewed
Aug 26, 2024
| strict: false, | ||
| }, | ||
| }) | ||
| export class JobDetails extends CoreEntity<JobDetails> { |
samarpan-b
reviewed
Aug 26, 2024
| import {GetJobDetailsFn, JobResponse, JobStatus} from '../types'; | ||
|
|
||
| @injectable({scope: BindingScope.TRANSIENT}) | ||
| export class GetJobDetailsProvider implements Provider<GetJobDetailsFn> { |
There was a problem hiding this comment.
RetrieveArchivedDataProvider
samarpan-b
reviewed
Aug 26, 2024
| import {ProcessImportedData} from '../types'; | ||
|
|
||
| @injectable({scope: BindingScope.TRANSIENT}) | ||
| export class ProcessImportedDataProvider |
There was a problem hiding this comment.
ProcessRetrievedDataProvider
samarpan-b
reviewed
Aug 26, 2024
| * return the json data to user | ||
| */ | ||
|
|
||
| async import(jobId: string) { |
There was a problem hiding this comment.
Entire flow for retrieval should be in this service file
samarpan-b
reviewed
Aug 26, 2024
| data.push(...fileContent); | ||
| } | ||
|
|
||
| const dsName = 'db'; |
There was a problem hiding this comment.
refactor this code. ensure connection is closed gracefully
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gh-1778
Description
Added a new package for entity level archival
Fixes #1778
Type of change
Please delete options that are not relevant.
Checklist: