Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bpmn-service): add camunda implementation, add tests #2135

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

feat(bpmn-service): add camunda implementation, add tests #2135

wants to merge 6 commits into from

Conversation

akshatdubeysf
Copy link
Contributor

BREAKING CHANGE:
restructuring of component binding, refer readme

Description

  • add a default implementation to support camunda 7
  • added acceptance tests that test on actual camunda
  • resolved an issue where workflow was saved in camunda but not in our db
  • add observer for listing to commands

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Intermediate change (work in progress)

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Any dependent changes have been merged and published in downstream modules

@akshatdubeysf
feat(bpmn-service): add camunda implementation, add tests
99e54ac 
BREAKING CHANGE:
restructuring of component binding, refer readme
@akshatdubeysf akshatdubeysf requested a review from a team as a code owner July 22, 2024 06:17
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
20.6% Duplication on New Code

See analysis details on SonarCloud

@yeshamavani
Copy link
Contributor

Why is this a breaking change

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
20.6% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yeshamavani yeshamavani yeshamavani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akshatdubeysf @yeshamavani