-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(authentication-service): added idp server controller for login and discovery endpoint #2131
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can not see all the endpoints mentioned here, https://docs.google.com/document/d/1r2v55eC5dbGBsA5ka_JQnzIIO80hdTqA6p8qCRKQmqU/edit
Also please specify and work on key rotation
0550723
to
8aafdb7
Compare
…d discovery endpoint BREAKING CHANGE:
|
@@ -25,6 +25,7 @@ | |||
} | |||
}, | |||
"scripts": { | |||
"start": "node -r source-map-support/register .", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this ?
}) | ||
req: RefreshTokenRequest, | ||
): Promise<SuccessResponse> { | ||
const token = auth?.replace(/bearer /i, ''); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cant we reuse existing code ?
Description
Added IDP server controller for login and discovery endpoint
Fixes # (issue) #2034
Type of change
Please delete options that are not relevant.
Checklist: