-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): fix sonar issues #2127
Conversation
fix sonar issues 2126
remove sonar issues 2126
remove sonar issues 2126
|
if (this.options.applicationClassName && this.options.relativePathToApp) { | ||
let appImport = ''; | ||
|
||
let appImport = ''; | ||
const isDefaultExport = await this._isDefaultExport( | ||
this.options.applicationClassName, | ||
this.options.relativePathToApp, | ||
); | ||
|
||
const isDefaultExport = await this._isDefaultExport( | ||
this.options.applicationClassName!, | ||
this.options.relativePathToApp!, | ||
); | ||
const appImportPath = this._getAppImportPath( | ||
this.options.relativePathToApp, | ||
); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why using an if else block
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
type of this.options.applicationClassName is string | undefined, but _isDefaultExport require arguement to be string only
fix sonar issues
2126
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #2126
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: