Skip to content

chore: add --namespace to install docs #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brendan-kellam wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −1
Open

chore: add --namespace to install docs #106

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ redis:
helm repo add sourcebot https://sourcebot-dev.github.io/sourcebot-helm-chart
helm repo update
helm install sourcebot sourcebot/sourcebot \
--namespace sourcebot --create-namespace \
-f values.yaml \
--set-json "sourcebot.config=$(cat config.json)"
```
Expand All @@ -88,6 +89,7 @@ helm install sourcebot sourcebot/sourcebot \
```bash
helm repo update
helm upgrade sourcebot sourcebot/sourcebot \
--namespace sourcebot \
-f values.yaml \
--set-json "sourcebot.config=$(cat config.json)"
```
Expand Down Expand Up @@ -394,7 +396,7 @@ sourcebot:
To uninstall/delete the `sourcebot` deployment:

```bash
helm uninstall sourcebot
helm uninstall sourcebot --namespace sourcebot
```

This removes all Kubernetes components associated with the chart but **preserves PersistentVolumeClaims (PVCs) by default**. This includes:
Expand All @@ -405,5 +407,10 @@ This removes all Kubernetes components associated with the chart but **preserves
To also remove all PVCs (⚠️ **this will delete all your data**):

```bash
<<<<<<< Updated upstream
kubectl delete pvc -l app.kubernetes.io/instance=sourcebot
```
=======
kubectl delete pvc -l app.kubernetes.io/instance=sourcebot --namespace sourcebot
```
>>>>>>> Stashed changes
Comment on lines +410 to +416
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical | ⚡ Quick win

Unresolved merge conflict must be fixed.

This merge conflict blocks the PR from being merged. Based on the PR objectives to add namespace flags throughout the documentation, the correct resolution is to keep the version that includes --namespace sourcebot.

🔧 Proposed fix to resolve the merge conflict 
-<<<<<<< Updated upstream
-kubectl delete pvc -l app.kubernetes.io/instance=sourcebot
-```
-=======
 kubectl delete pvc -l app.kubernetes.io/instance=sourcebot --namespace sourcebot

->>>>>>> Stashed changes

</details>

<details>
<summary>🧰 Tools</summary>

<details>
<summary>🪛 markdownlint-cli2 (0.22.1)</summary>

[warning] 415-415: Fenced code blocks should have a language specified

(MD040, fenced-code-language)

</details>

</details>

<details>
<summary>🤖 Prompt for AI Agents</summary>

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @README.md around lines 410 - 416, Resolve the unresolved merge conflict in
README.md by removing the Git conflict markers (<<<<<<<, =======, >>>>>>>) and
keep the line that includes the namespace flag: kubectl delete pvc -l
app.kubernetes.io/instance=sourcebot --namespace sourcebot; ensure only that
single corrected command remains in the fenced code block and no conflict
markers or duplicate lines remain.


</details>

<!-- fingerprinting:phantom:triton:puma -->

<!-- 4e71b3a2 -->

<!-- This is an auto-generated comment by CodeRabbit -->

Loading