-
Notifications
You must be signed in to change notification settings - Fork 0
Chapter selection #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This reverts commit abc9b32.
|
@mug1wara26 Could you help with the merge conflicts? |
|
strange i removed the conflict markers using the github editor but it didnt actually remove them |
|
Can you help take a look into this again? I tried changing to Chapter to 4, but it is sending the updated |
I'm unable to reproduce this issue, could you test it again? output.mp4 |
|
Hi, any update on this PR? |
|
When I last tested it still worked for me, I can work on resolving merge conflicts during the weekend |
Great, thanks a lot! I think if we can push out an update it would be good and also prevent confusion |
|
Hi @RichDom2185 I fixed the merge conflicts and it seems to be working on my end, switching the chapter on the playground updates the LSP, and diagnostics appear/disappear immediately. Could you test it out too to make sure it works on your end as well? |
|
Since Source 2 is being taught right now, I'll merge this so that the students can test it out |
Implementation for #11