Skip to content

Remove Concurrent and Interpreter #3130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Remove Concurrent and Interpreter #3130

wants to merge 13 commits into from

Conversation

leeyi45
Copy link
Contributor

@leeyi45 leeyi45 commented Apr 24, 2025

Removal of the concurrent variant as well as the legacy interpreter.

I'm not sure if the functionality from manualToggleDebugger (including interrupt and paused) is still required within WorkspaceSaga. I have that commented out right now, but if anyone could comment on that that would be great.

@coveralls
Copy link

coveralls commented Apr 27, 2025

Pull Request Test Coverage Report for Build 14700394275

Details

  • 171 of 343 (49.85%) changed or added relevant lines in 20 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.09%) to 31.019%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/commons/sagas/PersistenceSaga.tsx 0 2 0.0%
src/commons/redux/utils.ts 10 13 76.92%
src/commons/repl/Repl.tsx 2 6 33.33%
src/commons/sagas/SafeEffects.ts 7 11 63.64%
src/commons/sagas/StoriesSaga.ts 1 6 16.67%
src/commons/sagas/AchievementSaga.ts 1 8 12.5%
src/commons/sagas/LoginSaga.ts 1 8 12.5%
src/commons/sagas/RemoteExecutionSaga.ts 1 10 10.0%
src/commons/sagas/PlaygroundSaga.ts 16 46 34.78%
src/commons/sagas/WorkspaceSaga/helpers/evalCode.ts 29 64 45.31%
Files with Coverage Reduction New Missed Lines %
src/commons/sagas/WorkspaceSaga/index.ts 1 55.47%
src/commons/sagas/AchievementSaga.ts 3 0.68%
Totals Coverage Status
Change from base Build 14494411351: -0.09%
Covered Lines: 4866
Relevant Lines: 14787

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants