Skip to content

Leaderboard #3113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 49 commits into
base: master
Choose a base branch
from
Open

Leaderboard #3113

wants to merge 49 commits into from

Conversation

tohyzhong
Copy link

@tohyzhong tohyzhong commented Mar 8, 2025 •
edited
Loading

Description

  • Added Overall Leaderboard and Contest Leaderboards
  • XP and contest score fetching from backend
  • podium display for each leaderboard
  • customise number of entries to display in overall leaderboard in course config panel and create courses
  • dropdown to switch between leaderboards
  • routing to different leaderboards (url + dropdown)
  • links for contest entries
  • added contest scores update button in ground control (under voting features)
  • export as CSV for admins and staff
  • contest score updating
  • contest xp issuing for contest winners
  • Fixed code links from leaderboard without using setTimeout
  • Customise XP issuing for contest winners in contest voting XML file
  • Default Source Academy Profile pictures in Leaderboard based on NUSNet ID

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

How to test

Checklist

  • I have tested this code
  • I have updated the documentation

@tohyzhong tohyzhong requested a review from RichDom2185 March 8, 2025 12:15
@tohyzhong tohyzhong self-assigned this Mar 8, 2025
@tohyzhong tohyzhong marked this pull request as ready for review March 9, 2025 10:24
@tohyzhong tohyzhong marked this pull request as draft March 9, 2025 10:25
tohyzhong and others added 12 commits March 10, 2025 00:31
@tohyzhong
Fix import order in AssessmentWorkspace component
5b6755d
@tohyzhong
Refactor contest score calculation logic in Ground Control
62ea438
@Blerargh
Modularisation of Leaderboard subcomponents
1c0c5c2
@Blerargh
Formatting changes
9f2b2a9
@tohyzhong
Dropdown, csv Export, Podium fixes
7f65d1c
@tohyzhong
Set filename for Contests and Overall Leaderboard csv
b72b813
@RichDom2185
Use no payload type
1360753
@RichDom2185
Remove unused parameter
4aed281
@tohyzhong
Refactor LeaderboardExportButton to accept dynamic type and update fi…
75ec8a1 
…lename logic
@tohyzhong
Add contests state and actions to leaderboard management.
ba4b33b 
Added top X for contest Leaderboard (create course dropdown and course admin panel)
Added Top X for assessment workspace contest leaderboard and fixed export contest leaderboard (assessment workspace)
Fixed Leaderboard dropdown to show only published contests and omit voting assessments.
@tohyzhong
Add DispatchContestXp functionality and button to issue contest XP in…
b78304a 
… ground control
@tohyzhong
Refactor leaderboard components to use slice for top entries instead …
0a41698 
…of filter
@tohyzhong tohyzhong marked this pull request as ready for review March 18, 2025 17:02
@tohyzhong tohyzhong marked this pull request as draft March 18, 2025 17:02
@tohyzhong tohyzhong marked this pull request as ready for review April 16, 2025 10:44
@tohyzhong tohyzhong closed this Apr 16, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in SA 2526 CP3108 P09: Leaderboard Apr 16, 2025
@tohyzhong tohyzhong reopened this Apr 16, 2025
@tohyzhong tohyzhong marked this pull request as draft April 16, 2025 10:47
@tohyzhong tohyzhong marked this pull request as ready for review April 16, 2025 11:08
@sayomaki
Copy link
Contributor

Can you run the yarn format command first to fix the lint issues?

tohyzhong and others added 13 commits April 17, 2025 20:14
@tohyzhong
Merge branch 'master' into leaderboard
5c29fbe
@tohyzhong
Refactor: Improve code formatting and consistency across leaderboard …
f9390e9 
…components
@tohyzhong
Refactor: Remove unnecessary console.log from ContestLeaderboard comp…
c8d3102 
…onent
@RichDom2185
Remove files not supposed to be committed
1e4f255
@RichDom2185
Revert incorrect DTS changes
1dc925b
@RichDom2185
Avoid spaces in file names
3243538
@RichDom2185
Standardize reducer import
826f3ee
@RichDom2185
Fix inconsistent HTML label for
dda7e4b
@RichDom2185
Organize imports
0185023
@Blerargh
Added support for retrieving only relevant rows in leaderboard page
5040583
@tohyzhong
Refactor leaderboard data handling to support pagination and update r…
e94cc50 
…elated actions and types
@tohyzhong
Updated leaderboard podium logic
e08c26c
@tohyzhong
Enhance leaderboard functionality to support visible entries in conte…
2ea8cf0 
…st scores and popular votes, update API endpoints, and refactor export button logic.
@tohyzhong
Update Contest Leaderboard export to support all users
7c07b48
@tohyzhong
Refactor leaderboard saga and actions for improved readability and ma…
4859269 
…intainability; update ContestLeaderboard and OverallLeaderboard components for better state management and data retrieval.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RichDom2185 RichDom2185 Awaiting requested review from RichDom2185

At least 1 approving review is required to merge this pull request.

Assignees

@Blerargh Blerargh

@tohyzhong tohyzhong

Labels
None yet
Projects
SA 2526 CP3108 P09: Leaderboard
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tohyzhong @sayomaki @Blerargh @RichDom2185 @martin-henz