Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kea] New plugin for kea dhcp/ddns server #3655

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

jcastill
Copy link
Member

@jcastill jcastill commented Jun 6, 2024

This plugin captures config files and status of
the Kea DHCPv4/DHCPv6 and DDNS server by ISC.

Related: RHEL-40285


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname [email protected]?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?
  • Are all passwords or private data gathered by this PR obfuscated?

Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-3655
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@arif-ali
Copy link
Member

arif-ali commented Jun 7, 2024

You can add a UbuntuPlugin to this well

4 services that are possible

root@noble01:~# systemctl list-unit-files | grep kea
kea-ctrl-agent.service                       enabled         enabled
kea-dhcp-ddns-server.service                 enabled         enabled
kea-dhcp4-server.service                     enabled         enabled
kea-dhcp6-server.service                     enabled         enabled

The keactrl command doesn't seem to exist for Ubuntu.

We may as well do the postproc you're doing here in the main class where we're collecting /etc/kea and then add the Ubuntu stuff specifically there

@jcastill
Copy link
Member Author

The services are the same in RHEL/Fedora.
Apart from keactrl, what else is different in Ubuntu?

@arif-ali
Copy link
Member

The services are the same in RHEL/Fedora. Apart from keactrl, what else is different in Ubuntu?

From my initial research, I didnt find any other differences

@jcastill
Copy link
Member Author

jcastill commented Jul 3, 2024

New version with the comments addressed, hopefully. I tested the plugin in Ubuntu as well, to make sure the obfuscation was working as expected.

Copy link
Member

@arif-ali arif-ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good overall, thanks

minor nits

sos/report/plugins/kea.py Outdated Show resolved Hide resolved
sos/report/plugins/kea.py Outdated Show resolved Hide resolved
@pmoravec
Copy link
Contributor

Regarding Draft of the PR: @jcastill do you plan to modify the plugin in either way? If not, as we ACKed the current code, please change the type of PR so we can merge it.

@jcastill jcastill marked this pull request as ready for review August 22, 2024 06:31
@jcastill
Copy link
Member Author

Moved out from draft PR, so feel free to merge when you are ready.


class Kea(Plugin, UbuntuPlugin):
"""
Kea is a Kea is the next generation of DHCP software, developed by Internet
Copy link
Member

@TurboTurtle TurboTurtle Aug 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo here, "Kea is a Kea is".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in next version

Comment on lines 46 to 48
self.add_cmd_output([
"keactrl status",
])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it exists for Ubuntu - https://manpages.ubuntu.com/manpages/kinetic/man8/keactrl.8.html

A quick Google makes it look like it's part of the standard packaging, so we can make this a regular collection and shift this plugin to IndependentPlugin. Worst case scenario on a system that doesn't have it, we get a log message about the command not being found.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I've reworked it a bit so it covers Ubuntu better, thanks for finding this out.

This plugin captures config files and status of
the Kea DHCPv4/DHCPv6 and DDNS server by ISC.

Related:  RHEL-40285

Signed-off-by: Jose Castillo <[email protected]>
@TurboTurtle TurboTurtle merged commit d3a50e1 into sosreport:main Sep 2, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants