-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kea] New plugin for kea dhcp/ddns server #3655
Conversation
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
You can add a UbuntuPlugin to this well 4 services that are possible
The We may as well do the postproc you're doing here in the main class where we're collecting |
The services are the same in RHEL/Fedora. |
From my initial research, I didnt find any other differences |
6f8bbc8
to
06b080f
Compare
New version with the comments addressed, hopefully. I tested the plugin in Ubuntu as well, to make sure the obfuscation was working as expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good overall, thanks
minor nits
06b080f
to
26cc7b4
Compare
Regarding Draft of the PR: @jcastill do you plan to modify the plugin in either way? If not, as we ACKed the current code, please change the type of PR so we can merge it. |
Moved out from draft PR, so feel free to merge when you are ready. |
sos/report/plugins/kea.py
Outdated
|
||
class Kea(Plugin, UbuntuPlugin): | ||
""" | ||
Kea is a Kea is the next generation of DHCP software, developed by Internet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo here, "Kea is a Kea is".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in next version
sos/report/plugins/kea.py
Outdated
self.add_cmd_output([ | ||
"keactrl status", | ||
]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like it exists for Ubuntu - https://manpages.ubuntu.com/manpages/kinetic/man8/keactrl.8.html
A quick Google makes it look like it's part of the standard packaging, so we can make this a regular collection and shift this plugin to IndependentPlugin
. Worst case scenario on a system that doesn't have it, we get a log message about the command not being found.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I've reworked it a bit so it covers Ubuntu better, thanks for finding this out.
This plugin captures config files and status of the Kea DHCPv4/DHCPv6 and DDNS server by ISC. Related: RHEL-40285 Signed-off-by: Jose Castillo <[email protected]>
26cc7b4
to
762848a
Compare
This plugin captures config files and status of
the Kea DHCPv4/DHCPv6 and DDNS server by ISC.
Related: RHEL-40285
Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines