Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ocp] Replace 'oc --config' command #3516

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

jcastill
Copy link
Member

@jcastill jcastill commented Feb 9, 2024

The option --config was moved to --kubeconfig in
OCP 4.7.

Related: RH: RHEL-24402


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname [email protected]?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?

Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-3516
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@arif-ali
Copy link
Member

arif-ali commented Feb 9, 2024

would it not make sense to combine #3515 and this together, as you're changing the same file?

@jcastill
Copy link
Member Author

jcastill commented Feb 9, 2024

there are three different issues with collect in OCP, and we need the granularity. Having one big commit with more than one fix has caused unnecessary complexity for both support and testing in the past.

The option --config was moved to --kubeconfig in
OCP 4.7.

Related: RH: RHEL-24402

Co-authored-by: Alberto Losada Grande <[email protected]>

Signed-off-by: Jose Castillo <[email protected]>
@TurboTurtle TurboTurtle merged commit cdb66e8 into sosreport:main Feb 9, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants