Skip to content
This repository was archived by the owner on Mar 16, 2021. It is now read-only.

Change username properties #50

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Change username properties #50

wants to merge 1 commit into from

Conversation

@andreaubbiali
Copy link
Contributor

@andreaubbiali andreaubbiali commented Nov 5, 2018

  • increase max length to 40 chars
  • allow dots and underscores
  • fix test

sgotti
sgotti suggested changes Nov 6, 2018
View reviewed changes
Copy link
Member

@sgotti sgotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Just a small nit, then it LGTM.

command/command.go Outdated
"time"

"github.com/asaskevich/govalidator"
"github.com/pkg/errors"
Copy link
Member

@sgotti sgotti Nov 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These imports were below and with a new line from the Iocal ones to separate them (it's idiomatic doing this with go just for clearness). Can you please remove this change?

@2h3ph3rd
Fix username
cad0346 
- increase max length to 40 chars
- allow dots and underscores
- fix test
@andreaubbiali andreaubbiali changed the title Fix username Change username properties Nov 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@sgotti sgotti sgotti requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andreaubbiali @sgotti @2h3ph3rd