feat: 커피챗 상세페이지 Dialog 구현 #1619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
🚀 프리뷰 배포 확인하기 🚀 |
pepperdad
reviewed
Oct 31, 2024
| <Text mt={30} typography='SUIT_24_B'> | ||
| 커피챗 제안하기 | ||
| </Text> | ||
| <Text style={{"textAlign":"center","lineHeight":"22px"}} mt={14} typography='SUIT_14_M' color={colors.gray300}> |
There was a problem hiding this comment.
p1:
Suggested change
| <Text style={{"textAlign":"center","lineHeight":"22px"}} mt={14} typography='SUIT_14_M' color={colors.gray300}> | |
| <Text style={{ textAlign: 'center', lineHeight: '22px' }} mt={14} typography='SUIT_14_M' color={colors.gray300}> |
여기 인라인스타일로 된 부분 모두 따옴표 없어야할 것 같은데!!! 혹시 저장할 때 자동으로 안바뀌나요??
| </Text> | ||
| <TextWrapper> | ||
| <StyledText mt={48} color={colors.white} > | ||
| 회신 받을 본인 연락처 <span style={{"color":"#F77234"}}>*</span> |
There was a problem hiding this comment.
Suggested change
| 회신 받을 본인 연락처 <span style={{"color":"#F77234"}}>*</span> | |
| 회신 받을 본인 연락처 <span style={{color: "#F77234"}}>*</span> |
| /> | ||
| <TextWrapper> | ||
| <StyledText mt={46} color={colors.white} > | ||
| 무엇이 궁금하신가요? <span style={{"color":"#F77234"}}>*</span> |
There was a problem hiding this comment.
p1:
Suggested change
| 무엇이 궁금하신가요? <span style={{"color":"#F77234"}}>*</span> | |
| 무엇이 궁금하신가요? <span style={{color: "#F77234"}}>*</span> |
Comment on lines
24
to
26
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
앗 제 로컬 eslint가 로직이 꼬여버린 것 같습니다. 수정해서 적용완료했어요!
pepperdad
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤫 쉿, 나한테만 말해줘요. 이슈넘버
🧐 어떤 것을 변경했어요~?
커피챗 용 Dialog 뷰 및 기능, API 구현까지 완료했습니다
🤔 그렇다면, 어떻게 구현했어요~?
기존에 쓰던 Dialog에, 저번 고도화떄 만들어놓은 커스텀 Confirm을 사용해서 토스 라이브러리와의 충돌을 방지했습니당.
❤️🔥 당신이 생각하는 PR포인트, 내겐 매력포인트.
웹파트 행사를 위해 퀵 앤 러시로 2일만에 만들게 되어서 후에 조금은 리팩토링 하면 좋을 것 같습니다 ㅎ...
📸 스크린샷, 없으면 이것 참,, 섭섭한데요?