Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

del: 배포 관련 파일인 docker-compose.yml과 deploy.sh 스크립트 제거 완료 #518

Merged
merged 2 commits into from
Dec 27, 2024

Conversation

hoonyworld
Copy link
Member

👩‍💻 Contents

  • ubuntu 서버 내에서도 관리하고 있기 때문에 이중관리의 번거로움이 있다고 판단하여, ubuntu 서버에서만 관리하고자 합니다.
  • 따라서 배포 관련 파일인 docker-compose.yml과 deploy.sh 스크립트를 제거합니다.

📝 Review Note

📣 Related Issue

✅ 점검사항

  • docker-compose.yml 파일에 마이그레이션 한 API의 포워딩을 변경해줬나요?
  • Spring Secret 값을 수정하거나 추가했다면 Github Secret에서 수정을 해줬나요?
  • Nestjs Secret 값을 수정하거나 추가했다면 Docker-Compose.yml 파일 및 인스턴스 내부의 .env 파일을 수정했나요?

@hoonyworld hoonyworld requested a review from mikekks December 27, 2024 14:17
@hoonyworld hoonyworld self-assigned this Dec 27, 2024
Copy link

height bot commented Dec 27, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link
Member

@mikekks mikekks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

귯귯!

@hoonyworld hoonyworld merged commit bea47ca into develop Dec 27, 2024
1 check passed
@hoonyworld hoonyworld deleted the del/#513-v3 branch December 27, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

del: docker-compose 및 deploy 스크립트 제거
2 participants