Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 번쩍 관련 객체 정의 #508

Merged
merged 11 commits into from
Jan 15, 2025
Merged

feat: 번쩍 관련 객체 정의 #508

merged 11 commits into from
Jan 15, 2025

Conversation

mikekks
Copy link
Member

@mikekks mikekks commented Dec 21, 2024

👩‍💻 Contents

📝 Review Note

📣 Related Issue

✅ 점검사항

  • docker-compose.yml 파일에 마이그레이션 한 API의 포워딩을 변경해줬나요?
  • Spring Secret 값을 수정하거나 추가했다면 Github Secret에서 수정을 해줬나요?
  • Nestjs Secret 값을 수정하거나 추가했다면 Docker-Compose.yml 파일 및 인스턴스 내부의 .env 파일을 수정했나요?

@mikekks mikekks added the 🎁 feature 새로운 기능 label Dec 21, 2024
@mikekks mikekks requested a review from hoonyworld December 21, 2024 13:05
@mikekks mikekks self-assigned this Dec 21, 2024
Copy link

height bot commented Dec 21, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link
Member

@hoonyworld hoonyworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 민규님!

몇가지 수정하면 좋을 것 같은 부분이 있어서 코멘트 남겼습니다

@mikekks mikekks requested a review from hoonyworld January 13, 2025 15:10
Copy link
Member

@hoonyworld hoonyworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 민규님!

@mikekks mikekks requested a review from hoonyworld January 14, 2025 08:35
Copy link
Member

@hoonyworld hoonyworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@mikekks mikekks merged commit d3e1780 into develop Jan 15, 2025
1 check passed
@mikekks mikekks deleted the feat/#507 branch January 15, 2025 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎁 feature 새로운 기능 size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: 번쩍 객체 정의
2 participants