Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.3.0 #500

Merged
merged 3 commits into from
Dec 15, 2024
Merged

v2.3.0 #500

merged 3 commits into from
Dec 15, 2024

Conversation

mikekks
Copy link
Member

@mikekks mikekks commented Dec 15, 2024

๐Ÿ‘ฉโ€๐Ÿ’ป Contents

  • v2.3.0 ๋ฐฐํฌ

๐Ÿ“ Review Note

๐Ÿ“ฃ Related Issue

  • closed #

โœ… ์ ๊ฒ€์‚ฌํ•ญ

  • docker-compose.yml ํŒŒ์ผ์— ๋งˆ์ด๊ทธ๋ ˆ์ด์…˜ ํ•œ API์˜ ํฌ์›Œ๋”ฉ์„ ๋ณ€๊ฒฝํ•ด์คฌ๋‚˜์š”?
  • Spring Secret ๊ฐ’์„ ์ˆ˜์ •ํ•˜๊ฑฐ๋‚˜ ์ถ”๊ฐ€ํ–ˆ๋‹ค๋ฉด Github Secret์—์„œ ์ˆ˜์ •์„ ํ•ด์คฌ๋‚˜์š”?
  • Nestjs Secret ๊ฐ’์„ ์ˆ˜์ •ํ•˜๊ฑฐ๋‚˜ ์ถ”๊ฐ€ํ–ˆ๋‹ค๋ฉด Docker-Compose.yml ํŒŒ์ผ ๋ฐ ์ธ์Šคํ„ด์Šค ๋‚ด๋ถ€์˜ .env ํŒŒ์ผ์„ ์ˆ˜์ •ํ–ˆ๋‚˜์š”?

* chore: redis ์„ค์ • ์ถ”๊ฐ€

* chore: redis ๊ด€๋ จ ์˜์กด์„ฑ ์ถ”๊ฐ€

* feat(CoLeaderReader): ์บ์‹ฑ์„ ์œ„ํ•œ CoLeaderReader ๋ ˆ์ด์–ด ๊ตฌํ˜„

* refactor(CoLeaderRepository): CoLeader user ๊ด€๋ จ ๋ฐ์ดํ„ฐ ํŽ˜์น˜์กฐ์ธ ๊ตฌํ˜„

* refactor(ControllerExceptionAdvice): ์„œ๋ฒ„ ์—๋Ÿฌ ํŠธ๋ ˆ์ด์Šค๋ฅผ ์œ„ํ•ด ํŠธ๋ ˆ์ด์Šค ์Šคํƒ ์ถœ๋ ฅํ•˜๋„๋ก ๊ฐœ์„ 

* chore(ExecutionLoggingAop): redis ๊ด€๋ จ ์„ธํŒ… ๋กœ๊น… aop ์—์„œ ์ œ์™ธ

* chore(UserActivityVO): redis์— ์ €์žฅ๋˜์–ด ์žˆ๋Š” ๊ฐ์ฒด ์—ญ์ง๋ ฌํ™” ํ•˜๊ธฐ ์œ„ํ•œ ์ฝ”๋“œ ์ˆ˜์ •

* chore(ImageUrlVO): redis์— ์ €์žฅ๋˜์–ด ์žˆ๋Š” ๊ฐ์ฒด ์—ญ์ง๋ ฌํ™” ํ•˜๊ธฐ ์œ„ํ•œ ์ฝ”๋“œ ์ˆ˜์ •

* chore(Meeting):
1. mStartDate, mEndDate ์—ญ์ง๋ ฌํ™” ๋ฌธ์ œ๋ฅผ ์œ„ํ•ด getter ์„ ์–ธ
2. ๊ธฐ์กด์— ์‚ฌ์šฉ๋˜์—ˆ๋˜ getter ์ˆ˜์ •

* chore(BaseTimeEntity): LocalDateTime ์ง๋ ฌํ™” ๋ฐ ์—ญ์ง๋ ฌํ™” ๋ฌธ์ œ๋กœ ์ธํ•ด ์ฝ”๋“œ ์ถ”๊ฐ€

* chore(Meeting): LocalDateTime ์ง๋ ฌํ™” ๋ฐ ์—ญ์ง๋ ฌํ™” ๋ฌธ์ œ๋กœ ์ธํ•ด ์ฝ”๋“œ ์ถ”๊ฐ€

* feat(UserReader): ์บ์‹ฑ์„ ์œ„ํ•œ UserReader ๋ ˆ์ด์–ด ๊ตฌํ˜„

* feat(MeetingReader): ์บ์‹ฑ์„ ์œ„ํ•œ MeetingReader ๋ ˆ์ด์–ด ๊ตฌํ˜„

* chore: LazyLoading ๊ฐ์ฒด ์ €์žฅ ์˜ค๋ฅ˜ ํ•ด๊ฒฐ

* add(RedisConfig): redis ๊ด€๋ จ ์„ค์ • ์ถ”๊ฐ€

1. ์ง๋ ฌํ™”, ์—ญ์ง๋ ฌํ™” ๊ด€๋ จ๋œ ์„ค์ • ์ถ”๊ฐ€
2. ์บ์‹œ TTL 5์‹œ๊ฐ„ ์„ค์ •

* refactor(MeetingV2ServiceImpl): ์บ์‹œ๋ฅผ ํ™œ์šฉํ™˜ ์„ฑ๋Šฅ ์ตœ์ ํšŒ

1. ๋ชจ์ž„ ์กฐํšŒ : ๋ชจ์ž„, ๋ชจ์ž„์žฅ, ๊ณต๋™๋ชจ์ž„์žฅ ๊ด€๋ จ ๋ฐ์ดํ„ฐ ์บ์‹ฑ
2. ๋ชจ์ž„ ์ˆ˜์ • : 1๋ฒˆ์—์„œ ์บ์‹ฑํ•œ ๋ฐ์ดํ„ฐ ์ดˆ๊ธฐํ™”

* test(yml): redis ์„ค์ • ์ถ”๊ฐ€

* chore(User, Meeting): lazyLoading ๊ฐ์ฒด redis์— ์ €์žฅํ•˜์ง€ ์•Š๋„๋ก ๊ตฌํ˜„

* chore(RedisConfig): host์™€ port ๋ช…์‹œ์ ์œผ๋กœ ์„ค์ •

* feat(AbstractContainerBaseTest): redis ํ…Œ์ŠคํŠธ ์ปจํ…Œ์ด๋„ˆ ์ถ”๊ฐ€

* fix(AbstractContainerBaseTest): Property ์ˆ˜์ •

* chore(yml): dev redis ๊ฒฝ๋กœ ๋ณ€๊ฒฝ

* chore(cd-dev): ๋ฐฐํฌ ํ…Œ์ŠคํŠธ

* chore(cd-dev): ๋ฐฐํฌ ํ…Œ์ŠคํŠธ

* chore(cd-dev): ๋ฐฐํฌ ํ…Œ์ŠคํŠธ

* chore(cd-dev): ๋ฐฐํฌ ํ…Œ์ŠคํŠธ

* chore(UserReader): ๋ ˆ๋””์Šค์— ์บ์‹ฑํ•˜๋Š” ๋ฐ์ดํ„ฐ๋ฅผ User ์—์„œ MeetingCreatorDto ๋กœ ๋ณ€๊ฒฝ

* rename(redisContainerBaseTest): redisContainerBaseTest ์œผ๋กœ ํŒŒ์ผ ์ด๋ฆ„ ๋ณ€๊ฒฝ

* chore(redisContainerBaseTest): ์‹ฑ๊ธ€ํ†ค์œผ๋กœ ์ˆ˜์ •

* chore: redis ์ถ”๊ฐ€

* chore: redis localhost๋กœ ๋ณ€๊ฒฝ

* chore: readonly ์˜ต์…˜ ์ถ”๊ฐ€

* del(User): ์ฃผ์„์‚ญ์ œ

* chore(UserReader): readonly ์˜ต์…˜ ์ถ”๊ฐ€

* chore(RedisConfig): ๋””ํดํŠธ ttl ์„ค์ •, ์ดํ›„์— ๋‹ค๋ฅธ ttl ์ฃผ๊ธฐ์˜ ์บ์‹œ๊ฐ€ ํ•„์š”ํ•˜๋ฉด ์ถ”๊ฐ€ํ•  ์ˆ˜ ์žˆ๋„๋ก ๊ตฌํ˜„

* chore(ImageUrlVO): ํ•„๋“œ final ๋กœ ๋ณ€๊ฒฝ ๋ฐ ์ง๋ ฌํ™” ์„ค์ •

* chore(Meeting): ๊ธฐ์กด ์ƒํƒœ๋กœ ์›์ƒ๋ณต๊ตฌ

* feat(MeetingReader): Meeting ๋ฐ˜ํ™˜์ด ์•„๋‹Œ MeetingRedisDto ๋ฅผ ์‚ฌ์šฉ์œผ๋กœ ์ˆ˜์ •

* ๐Ÿšจfeat(CoLeaderReader): CoLeaders ๊ฐ€ ์•„๋‹Œ CoLeadersRedisDto ๋ฐ˜ํ™˜์œผ๋กœ ์ˆ˜์ •

1. User ์ƒ์„ฑ์ž์— ๋ถˆ๊ฐ€ํ”ผํ•˜๊ฒŒ id ์ถ”๊ฐ€
2. CoLeader ์— Meeting ํ•„๋“œ๋ฅผ ๋ถˆ๊ฐ€ํ”ผํ•˜๊ฒŒ null ๋กœ ์ €์žฅ

* chore(RedisConfig): objectMapper ์ปค์Šคํ…€ํ™”ํ•˜์—ฌ ๊ณตํ†ต์ ์œผ๋กœ ์‚ฌ์šฉํ•  ์ˆ˜ ์žˆ๊ฒŒ ๊ตฌํ˜„

* chore(MeetingV2ServiceImpl): ๋กœ์ง ๋ณ€๊ฒฝ์œผ๋กœ ์ธํ•œ ์ˆ˜์ •

* chore(MeetingV2GetMeetingByIdResponseDto): Meeting ์ƒ์„ฑ์ž ๋ณ€๊ฒฝ์—†์ด ํ•˜๊ธฐ ์œ„ํ•ด ๋ชจ์ž„ id ๋ฐ˜ํ™˜ ๋ฐฉ์‹์„ ๋ณ€๊ฒฝ

* chore: redis ์ปค๋„ฅ์…˜ ํ’€ ์„ค์ •

* chore: redis ๊ด€๋ จ ๊ธฐ๋Šฅ๋“ค๋งŒ ์ปค์Šคํ…€ objectMapper ์‚ฌ์šฉํ•˜๋„๋ก ์ˆ˜์ •

* chore(UserActivityVO): UserActivityVO final ์ถ”๊ฐ€

* chore(RedisProperties): RedisProperties ๋ฅผ ๋”ฐ๋กœ ์ •์˜ํ•˜์—ฌ ์‚ฌ์šฉ

* fix: ์ž˜๋ชป๋œ ์ฝ”๋“œ ์›์ƒ๋ณต๊ตฌ

* chore(CoLeaderReader): readonly ์ถ”๊ฐ€

* chore(ImageUrlVO): static -> ์ธ์Šคํ„ด์Šค ๋ฉ”์„œ๋“œ๋กœ ์ˆ˜์ •

* chore(cd): cd ํŠธ๋ฆฌ๊ฑฐ ์ˆ˜์ •

* chore(UserActivityVO): ๊ฒ€์ฆ ๋กœ์ง ์ถ”๊ฐ€

* chore(CoLeadersRedisDto): ๊ธฐ๋ณธ ์ƒ์„ฑ์ž ์ถ”๊ฐ€

* fix: ๊ธฐ์กด ์ฝ”๋“œ ๋ณต๊ตฌ

* feat(AuthV2ServiceImpl): ํšŒ์› ์ •๋ณด ์ˆ˜์ •๋œ ๊ฒฝ์šฐ์— ์บ์‹œ ์ดˆ๊ธฐํ™”

* feat(User): updateIfChanged ๋ฉ”์„œ๋“œ ๊ตฌํ˜„, withUserIdForRedis ๋ฉ”์„œ๋“œ ๊ตฌํ˜„

* chore(yml): ์ปค๋„ฅ์…˜ ํ’€ ์„ค์ • ์ œ๊ฑฐ

* chore(CoLeaderRedisDto): User ์ƒ์„ฑ ๋กœ์ง ์ˆ˜์ •

* chore(CoLeadersRedisDto): ๊ธฐ๋ณธ ํ•ด์‹œ๋งต ์ƒ์„ฑ์œผ๋กœ ๋ณ€๊ฒฝ

* test: ํŒŒํŠธ ๋ฐ ๊ธฐ์ˆ˜๊ฐ€ ์ž˜๋ชป๋์„ ๊ฒฝ์šฐ ์˜ˆ์™ธ ๋ฐœ์ƒ

* fix: NPE ๋ฌธ์ œ ํ•ด๊ฒฐ

* chore: ๊ฒ€์ฆ๋กœ์ง private ๋ฉ”์„œ๋“œํ™”
@mikekks mikekks added ๐Ÿš€ deployment ์ •๊ธฐ ๋ฐฐํฌ์™€ ๊ด€๋ จ๋œ ๋ผ๋ฒจ 2๏ธโƒฃ minor labels Dec 15, 2024
@mikekks mikekks requested a review from hoonyworld December 15, 2024 14:01
@mikekks mikekks self-assigned this Dec 15, 2024
Copy link

height bot commented Dec 15, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

๐Ÿ’กTip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@mikekks mikekks merged commit 774a232 into main Dec 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2๏ธโƒฃ minor ๐Ÿš€ deployment ์ •๊ธฐ ๋ฐฐํฌ์™€ ๊ด€๋ จ๋œ ๋ผ๋ฒจ size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants