Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ui): TextField 컴포넌트, FieldBox를 사용한 형태로 리팩토링. #195

Merged
merged 6 commits into from
Nov 2, 2024

Conversation

Brokyeom
Copy link
Member

@Brokyeom Brokyeom commented Oct 29, 2024

변경사항

  • TextField 컴포넌트를 FieldBox 컴포넌트 기반으로 수정합니다.
    • topAddon prop을 추가해 label, description 외 reactNode를 적용할 수 있도록 했습니다.
    • TextField의 bottomAddon prop은 FieldBox.BottomAddon의 rightAddon에 적용됩니다.

링크

시급한 정도

🏃‍♂️ 보통 : 최대한 빠르게 리뷰 부탁드립니다.

기타 사항

Copy link

changeset-bot bot commented Oct 29, 2024

🦋 Changeset detected

Latest commit: e270c27

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@sopt-makers/ui Patch
docs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Brokyeom Brokyeom changed the title Refactor/UI textfield refactor(ui): TextField 컴포넌트, FieldBox를 사용한 형태로 리팩토링. Nov 1, 2024
@Brokyeom Brokyeom marked this pull request as ready for review November 2, 2024 06:52
Copy link
Member

@jungwoo3490 jungwoo3490 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Brokyeom Brokyeom merged commit 37b6b9b into main Nov 2, 2024
1 check passed
@Brokyeom Brokyeom deleted the refactor/ui-textfield branch November 2, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants