Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Vitest globals 옵션 사용 시 lint error가 발생하는 문제를 해결합니다. #160

Merged
merged 4 commits into from
Oct 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/many-houses-hang.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sopt-makers/ui': patch
---

vitest globals 옵션 활성화로 인한 import문 제거
3 changes: 1 addition & 2 deletions packages/eslint-config-custom/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
"private": true,
"devDependencies": {
"@vercel/style-guide": "^5.0.0",
"eslint-config-turbo": "^1.10.12",
"eslint-plugin-vitest": "^0.5.4"
"eslint-config-turbo": "^1.10.12"
}
}
7 changes: 1 addition & 6 deletions packages/ui/.eslintrc.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,4 @@
const vitest = require('eslint-plugin-vitest');

module.exports = {
extends: ['custom/react-internal'],
plugins: ['vitest'],
rules: {
...vitest.configs.recommended.rules,
},
ignorePatterns: ['**/*.test.tsx'],
};
1 change: 0 additions & 1 deletion packages/ui/Button/test/Button.test.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { render, screen, fireEvent } from '@testing-library/react';
import { it, expect, vi } from 'vitest';
import Button from '../Button';

it('Button 컴포넌트가 정상적으로 렌더링됩니다.', () => {
Expand Down
1 change: 0 additions & 1 deletion packages/ui/Control/test/Checkbox.test.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { render, screen, fireEvent } from '@testing-library/react';
import { describe, expect, it, vi } from 'vitest';
import type { CheckBoxProps } from 'Control/CheckBox';
import { CheckBox } from '../index';

Expand Down
1 change: 0 additions & 1 deletion packages/ui/Control/test/Radio.test.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import type { RadioProps } from 'Control/Radio';
import { describe, expect, it, vi } from 'vitest';
import { render, screen, fireEvent } from '@testing-library/react';
import { Radio } from '../index';

Expand Down
1 change: 0 additions & 1 deletion packages/ui/Control/test/Toggle.test.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import { describe, expect, it, vi, beforeEach } from 'vitest';
import { render, screen, fireEvent } from '@testing-library/react';
import type { ToggleProps } from 'Control/Toggle';
import { Toggle } from '../index';
Expand Down
1 change: 0 additions & 1 deletion packages/ui/Tab/test/Tab.test.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { render, screen, fireEvent } from '@testing-library/react';
import { describe, it, expect, vi } from 'vitest';
import Tab from '../Tab';

describe('Tab 컴포넌트는', () => {
Expand Down
Loading
Loading