Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: release workflow에 pnpm setup action 추가 #130

Merged
merged 3 commits into from
Sep 13, 2024
Merged

Conversation

jungwoo3490
Copy link
Member

변경사항

pnpm으로 마이그레이션하면서 release workflow가 정상 동작하지 않았어요.

image

알아보니 actions/setup-node 액션을 사용하면 Node.js와 함께 yarn이 자동으로 설치되지만, pnpm은 그렇지 않다고 해요.
그래서 pnpm/action-setup@v2 액션을 추가하여 workflow에서 pnpm을 명시적으로 설치하고 사용할 수 있게 했어요.

image

그 결과 release workflow가 정상 동작하는 것을 확인했어요.

++ 추가 작업
pnpm으로 마이그레이션하면서 workspace를 pnpm-workspace.yaml이라는 별도의 파일에서 관리하게 되었는데, 아직 package.json에도 workspace 필드가 남아있어서 제거해주었습니다!

링크

시급한 정도

🏃‍♂️ 보통 : 최대한 빠르게 리뷰 부탁드립니다.

기타 사항

Copy link

height bot commented Sep 13, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link

changeset-bot bot commented Sep 13, 2024

⚠️ No Changeset found

Latest commit: fc5b529

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@Brokyeom Brokyeom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아따마 속도 상당하네요

@Brokyeom Brokyeom merged commit 138789f into main Sep 13, 2024
@Brokyeom Brokyeom deleted the fix/release-yml branch September 13, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants