Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes #21

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

changes #21

wants to merge 2 commits into from

Conversation

gnuoyohes
Copy link

  1. fixed bug where motors would move weirdly or hang when commands were incoming at too high of a frequency
    • created Movement class to handle executing incoming velocity commands
    • cmd_vel_callback now only sets the Movement's twist field
    • calls to the roboclaw_driver are now in the Node's run loop, preventing multiple callbacks trying to execute simultaneously
  2. added pub_odom and stop_movement params for extra configurability
  3. fixed typos 💯

Copy link

@humbertgim humbertgim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes solves most of the problems due to writing asynchronously to the serial port. I'm still battling to find a solution for the main loop to get stuck for no apparent reason

Copy link

sonarcloud bot commented Aug 9, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants