Skip to content

Fix ETH calculation overflow, add comprehensive price documentation, and setup CI/CD pipeline for SEQICO contract #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 7, 2025
Merged

Fix ETH calculation overflow, add comprehensive price documentation, and setup CI/CD pipeline for SEQICO contract #35

Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
679e1a3
Initial plan
Copilot Sep 1, 2025
4c0ee12
Fix ETH calculation error in SEQICO.sol buyWithETH function
Copilot Sep 1, 2025
b4d63bb
Rename ci-cd.yml to auto-assign.yml
sonnyquinn24 Sep 2, 2025
6b54682
Merge pull request #36 from sonnyquinn24/sonnyquinn24-patch-1
sonnyquinn24 Sep 2, 2025
1c745d7
Modify token price variables in SEQICO contract
sonnyquinn24 Sep 5, 2025
df8aae0
Refactor SEQICO constructor for clarity and consistency
sonnyquinn24 Sep 5, 2025
eb91fb6
Fix syntax errors and incorrect numbers in SEQICO contract
Copilot Sep 5, 2025
34b2d00
Add price documentation and examples for ETH, USDT, USDC values
Copilot Sep 5, 2025
f87f73d
Add ci-cd.yml workflow file
Copilot Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion contracts/SEQICO.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ contract SEQICO is Ownable {

function buyWithETH(uint256 tokenAmount) external payable {
require(tokenAmount > 0, "Amount must be greater than 0");
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

token amount $3.79

uint256 requiredETH = pricePerTokenETH * tokenAmount;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot fill in this info

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need clarification on what specific information you'd like me to add on line 40. Are you looking for:

  • A comment explaining the calculation formula?
  • Documentation about why we divide by 1e18?
  • Additional validation logic?

Please let me know what information you'd like me to fill in.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot correct and numbers that may be wrong

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot fix all errors

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed syntax errors and corrected all incorrect numbers in the contract. Removed erroneous decimal values from variable declarations and constructor parameters, while preserving the ETH calculation fix. Commit: df8aae0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed syntax errors and corrected all incorrect numbers in the contract. Removed erroneous decimal values from variable declarations and constructor parameters, while preserving the ETH calculation fix. Commit: df8aae0

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fill in the values for eth, usdc, usdt

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added example values for ETH, USDT, USDC pricing based on $3.79 token price. Created price-examples.js script showing calculations: ETH (0.001895), USDT (3790000), USDC (3790000). Added detailed documentation in the contract explaining each price variable. Commit: 34b2d00

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed all syntax issues and added comprehensive documentation for price calculations. Added detailed comments explaining the division by 1e18 and created example scripts showing how to set values for ETH, USDT, and USDC pricing. Commit: 34b2d00

uint256 requiredETH = pricePerTokenETH * tokenAmount / 1e18;
require(msg.value >= requiredETH, "Insufficient ETH sent");
require(seqToken.balanceOf(address(this)) >= tokenAmount, "Not enough SEQ tokens");

Expand Down
Loading