-
Notifications
You must be signed in to change notification settings - Fork 655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI support for SmartSwitch PMON #3271
Open
rameshraghupathy
wants to merge
145
commits into
sonic-net:master
Choose a base branch
from
rameshraghupathy:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+597
−58
Open
Changes from 2 commits
Commits
Show all changes
145 commits
Select commit
Hold shift + click to select a range
11cc04d
CLI support for SmartSwitch PMON
rameshraghupathy 02df0ea
imad minor fixes
rameshraghupathy e0e4700
Did some cleanup for backward compatibility
rameshraghupathy 0a8fc5a
removed the column wrapping
rameshraghupathy 6d61faa
Made it backward compatible and removed textwrap and added ut to PR
rameshraghupathy 8d95dae
1. There was a duplication of part of a function and that has been
rameshraghupathy 5c1b666
reboot_cause and system_health are obtained directly from chassisStateDB
rameshraghupathy fe4a8cf
The expected and result are the same but the test is throwing an error,
rameshraghupathy f896438
Let us get the build going and then look into the test mockup
rameshraghupathy 9d6c093
Implemented as per the pmon hld, also made some improvements in the
rameshraghupathy 0904515
Fixed the key for CHASSIS_MODULE_INFO_TABLE entries
rameshraghupathy ccc380b
Fixed "show reboot-cause all" and "show reboot-cause history all"
rameshraghupathy a8fa81d
Addressing review comments
rameshraghupathy 1cf96a0
Checking if the test issue still exists
rameshraghupathy 64fd559
Resolving SA errors triggered due to reboot_cause_test
rameshraghupathy d202e1c
Resolved pre-commit issues
rameshraghupathy b8c92ae
Resolved pre-commit issues
rameshraghupathy 9986f7b
Improving coverage
rameshraghupathy 0dc52f6
Fixed SA related warnings
rameshraghupathy 93df26d
Did some cleanup
rameshraghupathy 7a2aaf4
Minor improvements and fixes
rameshraghupathy 26f9b8a
Adding tests for system health
rameshraghupathy 3a592f8
Adding more system health related tests
rameshraghupathy 71472a8
Fixed a minor issue
rameshraghupathy fd8bd6b
Fixed long line SA issue
rameshraghupathy 5b15bc4
Trying to please SA
rameshraghupathy b35c987
Trying to improve coverage
rameshraghupathy ee10649
import mock
rameshraghupathy 27546a6
Fixed a typo
rameshraghupathy 883e35c
mocking DB
rameshraghupathy 713ffa2
Fixed syntax issues
rameshraghupathy 62fc3d0
DB mock fix
rameshraghupathy ecb2ecc
removed unused import
rameshraghupathy e2eb660
creating ut for dpu state
rameshraghupathy ef87cb5
Improving coverage
rameshraghupathy 53c2277
Fixed a typo
rameshraghupathy fb989e4
Adjusted the reboot-cause key as per the updated hld
rameshraghupathy 8ea7960
Added fix to gracefully handle sytem health DB keys not present case
rameshraghupathy 76de68a
Addressed minor review comments
rameshraghupathy a08e0cb
Addressed review comments. Commented out system-health support until
rameshraghupathy 766b303
Resolved minor issues and SA failures
rameshraghupathy c474940
Added role to PORT table in config_db. Using role to differentiate
rameshraghupathy 1910163
Resolving pre-commit check error related to line > 120
rameshraghupathy 851dc78
Trying to avoid pre-commit issues
rameshraghupathy cb54b73
Testing SA and precommit checks
rameshraghupathy 4dfb5f8
Making it backward compatible
rameshraghupathy 6941baf
Resolving column size and whitespace issue
rameshraghupathy f3c8e36
Working on SA issue
rameshraghupathy 6d7d539
Testing SA and UT
rameshraghupathy 433bc50
Added 2 spaces before inline comment
rameshraghupathy 3ddcc9c
Merge branch 'sonic-net:master' into master
rameshraghupathy 95da5c0
Enabling "show system-health dpu" cli alone. The rest of the dpu health
rameshraghupathy 627dd5e
Fixed SA issues
rameshraghupathy 934e6ef
Adde new line at EOF
rameshraghupathy 64d06ec
Enabling the UT for the CLI "show system-health dpu"
rameshraghupathy 4870a86
Resolved SA issues
rameshraghupathy fed3f67
Resolved a SA issue
rameshraghupathy 68b6416
Added smartswitch specific "reboot-cause" and "reboot-cause history" CLI
rameshraghupathy d229307
Removed the phase:2 related system-health cli extensions as a seperate
rameshraghupathy 78e71c5
Using smartswitch qualifier for the clie extensions
rameshraghupathy d7fbe9d
Fixed SA issues
rameshraghupathy 313a9d2
mocking device_info for test cases
rameshraghupathy 0ea1227
import patch in tests
rameshraghupathy f5f88bb
Debugging test failure
rameshraghupathy 62817ea
Fixing SA issues
rameshraghupathy 9fb005d
fixing sa issues
rameshraghupathy 7c8c5d7
Debugging sa issues
rameshraghupathy b5b068b
trying to resolve sa issues
rameshraghupathy 25259cb
fixed indentation
rameshraghupathy 808e7b4
debugging
rameshraghupathy 7eb8304
debugging
rameshraghupathy 44bed5c
debugging
rameshraghupathy d7fd0ce
debugging
rameshraghupathy b0e51f8
Debugging
rameshraghupathy ed742fc
debugging
rameshraghupathy 11f48f3
debugging
rameshraghupathy 402887d
Debugging
rameshraghupathy 8db11f3
Debugging
rameshraghupathy 2ab48b5
Debuggingg
rameshraghupathy e843fff
Debugging
rameshraghupathy 9ba21d2
Debugging
rameshraghupathy 738634d
Debugging
rameshraghupathy c491687
Debugging
rameshraghupathy ee3f927
Debugging
rameshraghupathy d47a431
Debugging
rameshraghupathy 04c520e
Debugging
rameshraghupathy c5abc01
Debugging
rameshraghupathy 6ab7742
Debugging
rameshraghupathy 4299ac3
Debugging
rameshraghupathy d30ead7
Debugging
rameshraghupathy a07e8c0
Debugging
rameshraghupathy a2cece6
Debugging
rameshraghupathy e2b65af
Debugging
rameshraghupathy 53909f0
Debugging
rameshraghupathy 9849436
Debugging
rameshraghupathy 02152e3
Debuggingg
rameshraghupathy a75a4d3
Debugging
rameshraghupathy f8a1f57
Debugging
rameshraghupathy 29000c3
Debugging
rameshraghupathy e273a16
Debugging
rameshraghupathy d720cf6
Debugging
rameshraghupathy c6040b3
Debugging
rameshraghupathy 864c96c
Debugging
rameshraghupathy 8580f76
Debugging
rameshraghupathy f4942b7
Debugging
rameshraghupathy 3e44844
Debugging
rameshraghupathy e7355b0
Debugging
rameshraghupathy b132f90
Debugging
rameshraghupathy 781270a
Debugging
rameshraghupathy 2e8813b
Debugging
rameshraghupathy 6cba5ed
Removing the test to build an image
rameshraghupathy 5db0bc2
Removed mock import
rameshraghupathy 807529f
Improving coverage
rameshraghupathy 885b168
pleasing SA
rameshraghupathy b6efa8c
Fixing tests for design changes as per review comments
rameshraghupathy 4c26a25
Resolving test failure
rameshraghupathy ed3d24b
fixed indentation
rameshraghupathy 68a9efe
cleaned up the test case
rameshraghupathy d09d58f
Addressed review comments in Command-Reference.md and trying to improve
rameshraghupathy c217c18
Improving coverage
rameshraghupathy df87438
Fixed a test issue
rameshraghupathy 2dfc2b5
Addressed review comments
rameshraghupathy c261b0c
Addressed review comment. Reading DPUs list from config_db.json
rameshraghupathy ab200bc
Improving coverage
rameshraghupathy 5e36792
Resolved SA error
rameshraghupathy 4a43780
Trying to improve coverage. Also, reading from platform.json
rameshraghupathy 8b2c9cb
adding json import in the test
rameshraghupathy 155ba3f
Fixed a test failure
rameshraghupathy e8c8b42
Fixed SA error
rameshraghupathy 9601177
Exercising the new function in test
rameshraghupathy 9713bf7
Removed a blank line
rameshraghupathy fdf8569
fixing mock issue
rameshraghupathy 4b30138
Trying a different approach
rameshraghupathy e725add
working on coverage
rameshraghupathy d2e7590
debugging
rameshraghupathy 3e1fc12
debugging
rameshraghupathy 51dce03
Debugging
rameshraghupathy a016ead
Increasing coverage
rameshraghupathy 041fad6
improving coverage
rameshraghupathy 5c85cf4
Adjusting the show cli implementation to align with the reboot-cause
rameshraghupathy 1b3fabb
Fixing a minor issue
rameshraghupathy 9a0225b
Removed ID column from the "show system-health dpu DPUx" cli as per t…
rameshraghupathy 8f191d6
Addressed default dpu admin status for dark-mode and seamless migration
rameshraghupathy 523a42c
Resolving SA issue
rameshraghupathy a90b878
Resolved a typo
rameshraghupathy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to perform additional validation to check if the chassis_module_name is actually present (or is an actual valid module name) or not, if user executes
config chassis modules startup DPU5
on a system which does not have DPU5, this will cause crash in chassisd for theSmartSwitchConfigManagerTask
in chassisd preventing further startup or shutdown calls (even though output of the command would beStarting up chassis module DPU1
orShutting down chassis module DPU1
the only operation which is performed is addition/removal from the CONFIG_DB )