Update to support SAI BFD_SESSION_OFFLOAD_TYPE. #1546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kcudnik
reviewed
Feb 27, 2025
kcudnik
reviewed
Feb 27, 2025
vslib/SwitchStateBase.cpp
Outdated
Comment on lines
1058
to
1071
| attr.id = SAI_SWITCH_ATTR_SUPPORTED_IPV4_BFD_SESSION_OFFLOAD_TYPE; | ||
| uint32_t list[1] = { SAI_BFD_SESSION_OFFLOAD_TYPE_FULL }; | ||
| if(!m_switchConfig->m_bfdOffload) { | ||
| list[0] = SAI_BFD_SESSION_OFFLOAD_TYPE_NONE; | ||
| } | ||
| attr.value.u32list.count = 1; | ||
| attr.value.u32list.list = list; | ||
| CHECK_STATUS(set(SAI_OBJECT_TYPE_SWITCH, m_switch_id, &attr)); | ||
|
|
||
| attr.id = SAI_SWITCH_ATTR_SUPPORTED_IPV6_BFD_SESSION_OFFLOAD_TYPE; | ||
| attr.value.u32list.count = 1; | ||
| attr.value.u32list.list = list; | ||
| CHECK_STATUS(set(SAI_OBJECT_TYPE_SWITCH, m_switch_id, &attr)); | ||
|
|
There was a problem hiding this comment.
add empty lines before if and after } and before and after CHECK_STATUS
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kcudnik
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for SAI_SWITCH_ATTR_SUPPORTED_IPV4_BFD_SESSION_OFFLOAD_TYPE and SAI_SWITCH_ATTR_SUPPORTED_IPV6_BFD_SESSION_OFFLOAD_TYPE in vslib. This is needed by BfdOrch in sonic-swss to choose between software BFD or regular (offloaded) BFD.
Default will be to return SAI_BFD_SESSION_OFFLOAD_TYPE_FULL, as this was the default behavior previously when this value was not checked.
Added capability to return SAI_BFD_SESSION_OFFLOAD_TYPE_NONE by setting SAI_VS_BFD_OFFLOAD_SUPPORTED=false in sai.profile for testing and in cases where software BFD is desired.