Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix counter issues on VS platform #1540

Merged
merged 6 commits into from
Feb 25, 2025
Merged

Conversation

stephenxs
Copy link
Contributor

@stephenxs stephenxs commented Feb 21, 2025

Fix two day 1 counter issues on VS platform which have been exposed recently.

  1. Use switch object to detect counter capability in flex counter. This is to fix the following error message

    E               2025 Feb 20 15:43:21.906623 vlab-03 ERR syncd#syncd: :- queryStatsCapability: parameter switchId oid:0x100000001 object type is SAI_OBJECT_TYPE_PORT, but expected SAI_OBJECT_TYPE_SWITCH
    E               
    E               2025 Feb 20 15:43:21.910428 vlab-03 ERR syncd#syncd: :- queryStatsCapability: parameter switchId oid:0x1500000003 object type is SAI_OBJECT_TYPE_QUEUE, but expected SAI_OBJECT_TYPE_SWITCH
    
  2. Support PFC counters on VS platform
    Previously it didn't check counter capability before polling PFC counters by mistake.

  3. Do not poll counters for a group without any counter supported by the system in bulk creation

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@stephenxs
Copy link
Contributor Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Stephen Sun <[email protected]>
@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@stephenxs stephenxs changed the title Use switch object to detect counter capability in flex counter Fix counter issues on VS platform Feb 23, 2025
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@stephenxs stephenxs requested a review from kcudnik February 25, 2025 09:02
@stephenxs stephenxs marked this pull request as ready for review February 25, 2025 09:02
@stephenxs
Copy link
Contributor Author

@kcudnik Could you please merge it? All tests passed.
Thanks

@kcudnik kcudnik merged commit bc85ac8 into sonic-net:master Feb 25, 2025
15 checks passed
@stephenxs stephenxs deleted the fix-query-stat branch February 25, 2025 14:16
@stephenxs
Copy link
Contributor Author

stephenxs commented Feb 27, 2025

cherry-pick conflict with 202412 due to dependency on #1527 which should be cherry-picked first

@mssonicbld
Copy link
Collaborator

Cherry-pick PR to msft-202412: Azure/sonic-sairedis.msft#35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants