Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[active-standby] support reset heartbeat suspend timer #286

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lolyu
Copy link
Contributor

@lolyu lolyu commented Feb 11, 2025

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • New feature
  • Doc/Design
  • Unit test

Approach

What is the motivation for this PR?

This is inspired from sonic-net/sonic-mgmt#16878; the active side could be stuck in the following loop if it cannot receive any heartbeats:

# (unknown, active, up) ----------------------------> (unknown, wait, up)
#         ^              suspend timeout, probe mux           |          
#         |                                                   |          
#         |                                                   |          
#         |                                                   |          
#         +---------------------------------------------------+          
#                mux active, suspend heartbeat with backoff

and the suspend timeout will backoff with max timeout as 128 * (negative retry + 1) * send interval; during this period, the mux port is unable to detect link failures as no heartbeats sending.
This PR is to support reset the suspend timer/backoff.

Signed-off-by: Longxiang Lyu [email protected]

Work item tracking
  • Microsoft ADO (number only): 31339123

How did you do it?

Support reset heartbeat suspend timer for active-standby state machine.

How did you verify/test it?

UT

Any platform specific information?

Documentation

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lolyu lolyu marked this pull request as ready for review February 12, 2025 09:37
@lolyu lolyu requested a review from yxieca February 12, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants