HLD document for configurable drop counter monitoring #1912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add a section for persistent drops - Add details on how to configure monitoring of persistent drop - Add a detailed diagram explaining the concept of persistent drop - Add CLI commands to show and configure drop counter monitors
|
/azp run |
|
No pipelines are associated with this pull request. |
This was referenced Feb 7, 2025
Open
|
@arista-hpandya can you please add the code PRs to this HLD by referring to #806 ? Thanks. |
|
Community review recording https://zoom.us/rec/share/Z8xcv_X_2l6LcIgv3hTKeO9Cvk6WLB9bgb_bym08uEmsG_2ygBRAxlcS0vu_UazX.35SIqDPFUjKJbsQU |
rminnikanti
reviewed
Feb 11, 2025
| - Argument: -ict / --incident-count-threshold | ||
| - Default: 2 | ||
|
|
||
| When enabled, the persistent drop counter monitor tracks all configured drop counters. These configurations apply globally to all drop counters. |
There was a problem hiding this comment.
This feature supports monitoring only port level drop counters, this information is not captured in the HLD.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What we did:
Added a persistent drop counter monitoring feature to identify persistent packet drops based on user-defined thresholds.
Why we did it:
The current implementation of drop counters in SONiC only provides visibility into the number of packets dropped. This enhancement introduces a way to identify persistent drops in packets based on a user-defined threshold, which can help with troubleshooting.
Support added:
Configurable drop counter monitoring is now supported on platforms that support both the SAI drop counter API and the query APIs.
CPU Overhead:
Minimal. Based on our testing, there was a nominal increase of the mean CPU utilization by 0.03 percentage points.
Memory Overhead:
Negligible. No changes in memory were observed.
Inspiration
The idea was presented by Arista team in SONiC 2023 Hackathon
Issues Tracked
Fixes #1542