[SmartSwitch-BFD] Update sections of SmartSwitchDpuLivenessUsingBfd HLD #1859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdbaig
commented
Dec 1, 2024
abdbaig
commented
- BFD sessions in FRR are no longer statically set to passive. This indication will directly from BFD_SESSION_TABLE using "type" field.
- Remove key DPU_ID from DASH_BFD_PROBE_STATE. This is not required since the table exists on individual DPUs.
- BfdOrch will use switch_type dpu to check if software BFD session needs to be programmed in FRR, rather than use SAI API to query for HW offload.
-BFD sessions in FRR are no longer statically set to passive. This indication will directly from BFD_SESSION_TABLE using "type" field. -Remove key DPU_ID from DASH_BFD_PROBE_STATE. This is not required since the table exists on individual DPUs. -BfdOrch will use switch_type dpu to check if software BFD session needs to be programmed in FRR, rather than use SAI API to query for HW offload.
|
/azp run |
|
No pipelines are associated with this pull request. |
prsunny
reviewed
Feb 13, 2025
|
|
||
| SOFTWARE_BFD_SESSION_TABLE entry in STATE_DB has all the key fields and values from BFD_SESSION_TABLE. | ||
| HA manager also creates another BFD passive multihop session in DPU using BFD_SESSION_TABLE in APP_DB with local DPU PA and peer NPU PAs. BfdOrch checks switch_type in DEVICE_METADATA table of CONFIG_DB and if it's dpu, FRR is configured to trigger BFD sessions. BfdOrch creates BFD_SOFTWARE_SESSION_TABLE entry in STATE_DB with same field-value as passed from BFD_SESSION_TABLE. This allows flexibiliy in setting session type and other parameters from hamgrd. |
There was a problem hiding this comment.
Please revert this section as the software bfd must be based on capability query in bfdorch. Rest of the changes regarding bgpcfgd looks fine. Can you please create a new PR to check capability since I merged the current swss PR?
There was a problem hiding this comment.
Will do - will update this PR once new PR is raised.
prsunny
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.