Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DASH Flow] Add SaiVal derivative before some arguments of set_flow_entry_attr to make configuration easier #643

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

ShaofengWu123
Copy link
Contributor

@ShaofengWu123 ShaofengWu123 commented Nov 11, 2024

This PR adds @SaiVal[type="sai_ip_address_t"] before the following arguments of action set_flow_entry_attr in dash flow:

  • underlay0_sip
  • underlay0_dip
  • underlay1_sip
  • underlay1_dip

There are mainly two reasons for doing this:

  • Other parts of the dash pipeline do so. For example, in action set_eni_attrs, every argument of type IPv4Address is added a @SaiVal[type="sai_ip_address_t"] before it.
  • Generated saithrift rpc can use IP address-related helper functions to assign a value to corresponding arguments instead of directly using a u32 type value, making the code more readable.

@r12f
Copy link
Collaborator

r12f commented Nov 14, 2024

ouch! @ShaofengWu123 do you mind to help take this PR to OCP SAI repo asap?

@r12f r12f merged commit 0726ca7 into sonic-net:main Nov 14, 2024
4 checks passed
@ShaofengWu123
Copy link
Contributor Author

ouch! @ShaofengWu123 do you mind to help take this PR to OCP SAI repo asap?

Sure, please check: opencomputeproject/SAI#2101.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants