Remove RIF SMAC attribute from HLD #280
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In general, the switch mac shall be same as RIF mac, but for packet forwarding, it is expected to use the RIF mac as src mac. So please keep the attribute. |
|
@prsunny While this is true for the switch, is it expected to be configured on a DPU? That's the additional attribute to support. |
I think yes, because router interface creation for DPU is similar to switch and we pass this attribute by default |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on BMv2 discussion, the SRC mac of egress packet should be set based on SMAC of switch, not RIF. So, looks like this RIF SAI_ROUTER_INTERFACE_ATTR_SRC_MAC_ADDRESS attribute is redundant in the doc, thus removing it. The SAI_SWITCH_ATTR_SRC_MAC_ADDRESS should used instead.