[hld]: Support for multiple routing type actions #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lawrence Lee <[email protected]>
theasianpianist
force-pushed
the
dash-action-list
branch
from
fe53e18
to
e5994fe
Compare
theasianpianist
commented
Nov 3, 2022
| ``` | ||
| key = DASH_ROUTING_TYPE_TABLE:routing_type; routing type can be {direct, vnet, vnet_direct, vnet_encap, appliance, privatelink, privatelinknsg, servicetunnel}; actions can be a list of action_types | ||
| DASH_ROUTING_TYPE_TABLE:{{routing_type}}:{{action_name}} | ||
| "action_type": {{action_type}} |
There was a problem hiding this comment.
Further changes will be needed here since we cannot guarantee that all actions for a routing type will be programmed at the same time - there may be a delay between them which need to be handled before we push the updates to SAI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some routing types require multiple actions to be performed in order. This PR updates the
DASH_ROUTING_TYPE_TABLEschema to allow for this by adding a second schema for the table. The existing schema will be used for all routing types requiring only a single action. Routing types requiring multiple actions will use the new schema.Signed-off-by: Lawrence Lee [email protected]