-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding the summary section #72
Conversation
Fullfilling the requirements stated in sonatype-nexus-community#14
Here I have added some basic styling for the table to display the number of vulnerabilities in red. Furthermore, I have removed the placeholder texts with the actual output.
Thanks for the PR! You've motivated me to get the main build working. Would you mind merging in the latest from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
])); | ||
table.add_row(Row::new(vec![ | ||
TableCell::new("Vulnerable Dependencies"), | ||
TableCell::new_with_col_span(style(vulnerability_count as u32).red(), 1), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor: remove cast
TableCell::new_with_col_span(style(vulnerability_count as u32).red(), 1), | |
TableCell::new_with_col_span(style(vulnerability_count).red(), 1), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
table.add_row(Row::new(vec![TableCell::new("Summary")])); | ||
table.add_row(Row::new(vec![ | ||
TableCell::new("Audited Dependencies"), | ||
TableCell::new_with_col_span(component_count as u32, 1), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor: could remove explicit cast: as u32
TableCell::new_with_col_span(component_count as u32, 1), | |
TableCell::new_with_col_span(component_count, 1), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, you are right. The as u32 is obsolete there. I am happy that you have seen it.
Hi!
I have just seen that the summary section for the project was still not implemented, so I have done the table styling
This pull request makes the following changes:
It relates to the following issue #s: