Clarified version of solo key reference #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated language so it's clearer that it's the user's solo key being referred to when the version is being reported.
Fix capitalization.
|
It seems to me that only the key has firmware, if you are convinced this helps I can merge. |
My1
suggested changes
Oct 29, 2019
| <span v-if="solo_version" v-text="solo_version"></span> | ||
| <span v-else>unknown</span> | ||
| <br> | ||
|
|
||
| Latest Solo Key firmware available version: | ||
| Latest Solo key firmware available version: |
There was a problem hiding this comment.
wouldnt it sound better of it would be
"Latest available Solo key firmware version"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated language so it's clearer that it's the user's solo key being referred to when the version is being reported.