-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
K8s 1.26 upgrade #542
K8s 1.26 upgrade #542
Conversation
tried generating code locally with
update: 🤦🏼 |
looks like my codegen differs from the build-bot one :rip: |
This reverts commit e376eca.
missing some generated code that didn't occur on my end |
…externalversions/factory.go for CI codegens failure
Issues linked to changelog: |
Reverted my try to move tests to GH Actions + created an issue for it #543 |
github.com/onsi/gomega v1.24.1 | ||
github.com/pkg/errors v0.9.1 | ||
github.com/pseudomuto/protoc-gen-doc v1.5.1 | ||
github.com/pseudomuto/protoc-gen-doc v1.5.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you know why this got downgraded?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm not sure, i'll check go-utils & k8s-utils to see which might've done it :hmm:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah not sure. looks like it was part of this commit where i bumped k8s-utils to a specific commit before its release. I think I can go get github.com/pseudomuto/[email protected]
if you think that'd be safer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's probably not a big deal, just curious that something caused it to downgrade
k8s-utils
version that has 1.26 bumps