resource snapshot v2 with slice (#544)

* resource snapshot v2 with slice * changelog * removed v2
solo-io · Apr 16, 2024 · b8d78e6 · b8d78e6
1 parent c0952ff
commit b8d78e6
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/changelog/v0.38.2/less-snapshot-allocs.yaml b/changelog/v0.38.2/less-snapshot-allocs.yaml
@@ -0,0 +1,3 @@
+changelog:
+  - type: NON_USER_FACING
+    description: Use make + len for snapshot copies to avoid allocations from growing the maps.
diff --git a/pkg/resource/snapshot.go b/pkg/resource/snapshot.go
@@ -62,7 +62,7 @@ func (s Snapshot) cloneInternal(deepCopy bool, selectors ...GVKSelectorFunc) Sna
 			if deepCopy {
 				clone[k] = copyNnsMap(v)
 			} else {
-				clone[k] = map[types.NamespacedName]client.Object{}
+				clone[k] = make(map[types.NamespacedName]client.Object, len(v))
 				maps.Copy(clone[k], v)
 			}
 			continue
@@ -78,7 +78,7 @@ func (s Snapshot) cloneInternal(deepCopy bool, selectors ...GVKSelectorFunc) Sna
 			if deepCopy {
 				clone[k] = copyNnsMap(v)
 			} else {
-				clone[k] = map[types.NamespacedName]client.Object{}
+				clone[k] = make(map[types.NamespacedName]client.Object, len(v))
 				maps.Copy(clone[k], v)
 			}
 			continue
@@ -127,7 +127,7 @@ func (s ClusterSnapshot) ForEachObject(
 }
 
 func copyNnsMap(m map[types.NamespacedName]client.Object) map[types.NamespacedName]client.Object {
-	nnsMapCopy := map[types.NamespacedName]client.Object{}
+	nnsMapCopy := make(map[types.NamespacedName]client.Object, len(m))
 	for k, v := range m {
 		nnsMapCopy[k] = v.DeepCopyObject().(client.Object)
 	}