Skip to content

Commit

Permalink
use slices as backing data structure for v2_sets (#540)
Browse files Browse the repository at this point in the history
* update

* remove compare resource ids

* add iter

* fix iter

* add iter impl

* add inefficient list as cop out

* add filters to inefficient list

* fix inefficient list

* fix inefficient list

* inefficient list inverted

* remove inefficient list

* add length method to set/

* update

* update

* update v2 sets with better funciton names

* update v2 sets with better funciton names

* remove FilterOutAndIterate method

* add Get

* add comments

* add changelog and remove test focus

* move changelog/

* move changelog

* fixes for PR review
  • Loading branch information
saiskee authored Apr 10, 2024
1 parent a016a57 commit 9f6b5ae
Show file tree
Hide file tree
Showing 5 changed files with 431 additions and 204 deletions.
8 changes: 8 additions & 0 deletions changelog/v0.38.0/sets-v2-iter.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
changelog:
- type: BREAKING_CHANGE
issueLink: https://github.com/solo-io/skv2/issues/543
description: >
v2 sets have been refactored to use a slice as the backing data structure, allowing for faster GC time of entire sets,
and more efficient iteration over the set. A few methods have been removed, namely `List` and `UnsortedList`, both which have been
replaced with a more accurate name: "FilterOutAndCreateList". In addition, a `Filter` and `Iter` method have been added to v2 sets.
skipCI: "false"
Loading

0 comments on commit 9f6b5ae

Please sign in to comment.