Skip to content

Commit

Permalink
Add typed object refs. (#107)
Browse files Browse the repository at this point in the history
* Add typed object refs.
* update comment
  • Loading branch information
harveyxia authored Jul 14, 2020
1 parent dccdb05 commit 7988931
Show file tree
Hide file tree
Showing 5 changed files with 429 additions and 36 deletions.
41 changes: 38 additions & 3 deletions api/core/v1/core.proto
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ message ObjectRef {
string namespace = 2;
}

// Resource reference for an object
// Resource reference for a cross-cluster-scoped object
message ClusterObjectRef {

// name of the resource being referenced
Expand All @@ -35,6 +35,41 @@ message ClusterObjectRef {
string cluster_name = 3;
}

// Resource reference for a typed object
message TypedObjectRef {

// API group of the resource being referenced
google.protobuf.StringValue api_group = 1;

// Kind of the resource being referenced
google.protobuf.StringValue kind = 2;

// name of the resource being referenced
string name = 3;

// namespace of the resource being referenced
string namespace = 4;
}

// Resource reference for a typed, cross-cluster-scoped object
message TypedClusterObjectRef {

// API group of the resource being referenced
google.protobuf.StringValue api_group = 1;

// Kind of the resource being referenced
google.protobuf.StringValue kind = 2;

// name of the resource being referenced
string name = 3;

// namespace of the resource being referenced
string namespace = 4;

// name of the cluster in which the resource exists
string cluster_name = 5;
}

// A generic status
message Status {

Expand Down Expand Up @@ -67,9 +102,9 @@ message Status {
int64 observed_generation = 3;

// The time at which this status was recorded
google.protobuf.Timestamp processing_time = 4;
google.protobuf.Timestamp processing_time = 4;

// (optional) The owner of the status, this value can be used to identify the entity which wrote this status.
// This is useful in situations where a given resource may have multiple owners.
google.protobuf.StringValue owner = 5;
}
}
4 changes: 4 additions & 0 deletions changelog/v0.7.2/typed-object-refs.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
changelog:
- type: NEW_FEATURE
description: Add dependencies to model.Chart for declaring Helm chart dependencies.
issueLink: https://github.com/solo-io/skv2/issues/106
Loading

0 comments on commit 7988931

Please sign in to comment.