Skip to content

Commit

Permalink
fix input reconciler template (#442)
Browse files Browse the repository at this point in the history
* fix template

* fix input snapshot

* changelog
  • Loading branch information
jenshu authored Apr 5, 2023
1 parent 177a4c4 commit 1900c61
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
4 changes: 4 additions & 0 deletions changelog/v0.29.5/fix-input-templates.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
changelog:
- type: FIX
description: Fix compilation errors in input reconciler and input snapshot templates when running with k8s 1.25 libraries.
issueLink: https://github.com/solo-io/gloo/issues/6833
2 changes: 1 addition & 1 deletion contrib/codegen/templates/input/input_reconciler.gotmpl
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ func RegisterSingleCluster{{ $snapshotName }}Reconciler(
Name: obj.Name,
Namespace: obj.Namespace,
}
_, err := r.base.ReconcileLocalGeneric(ezkube.ConvertRefToId(ref))
_, err := r.base.ReconcileLocalGeneric(ref)
return err
},
}, predicates...); err != nil {
Expand Down
2 changes: 1 addition & 1 deletion contrib/codegen/templates/input/input_snapshot.gotmpl
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ func (s *snapshot{{ $snapshotName }}) SyncStatusesMultiCluster(ctx context.Conte
{{- if $resource.Status }}
if opts.{{ $resource.Kind }} {
for _, obj := range s.{{ $kindPlural }}().List() {
clusterClient, err := mcClient.Cluster(obj.ClusterName)
clusterClient, err := mcClient.Cluster(ezkube.GetClusterName(obj))
if err != nil {
errs = multierror.Append(errs, err)
continue
Expand Down

0 comments on commit 1900c61

Please sign in to comment.