Fix changelog labels for storefront, i18n and legacy promotions - #6578
Open
jarednorman wants to merge 2 commits into
Open
Fix changelog labels for storefront, i18n and legacy promotions#6578jarednorman wants to merge 2 commits into
jarednorman wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6578 +/- ##
=======================================
Coverage 92.26% 92.26%
=======================================
Files 1037 1037
Lines 21228 21228
=======================================
Hits 19586 19586
Misses 1642 1642 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
solidus_storefront(#6468) andsolidus_i18n(#6537) were merged into the monorepo, we forgot to update the PR labeler. PRs touchingstorefront/ori18n/have been falling through to thechangelog:repositorycatch-all, which is why both merge PRs have that label.While fixing that, I noticed that
bin/release/update-release-draftonly emits PRs whose label has a categoryin
.github/release.ymland silently drops the rest.changelog:solidus_legacy_promotionshas never had a category, so legacy promotions PRs have been missing from generated release notes since that gem was split out. Between v4.6.2 and v4.7.0 alone, 8 PRs were dropped this way. It's a sad fate to be forgotten.Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: