Skip to content

Fix changelog labels for storefront, i18n and legacy promotions - #6578

Open
jarednorman wants to merge 2 commits into
solidusio:mainfrom
SuperGoodSoft:changelog-labels-storefront-i18n
Open

Fix changelog labels for storefront, i18n and legacy promotions#6578
jarednorman wants to merge 2 commits into
solidusio:mainfrom
SuperGoodSoft:changelog-labels-storefront-i18n

Conversation

@jarednorman

Copy link
Copy Markdown
Member

Summary

When solidus_storefront (#6468) and solidus_i18n (#6537) were merged into the monorepo, we forgot to update the PR labeler. PRs touching storefront/ or i18n/ have been falling through to the changelog:repository catch-all, which is why both merge PRs have that label.

While fixing that, I noticed that bin/release/update-release-draft only emits PRs whose label has a category
in .github/release.yml and silently drops the rest. changelog:solidus_legacy_promotions has never had a category, so legacy promotions PRs have been missing from generated release notes since that gem was split out. Between v4.6.2 and v4.7.0 alone, 8 PRs were dropped this way. It's a sad fate to be forgotten.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@jarednorman
jarednorman requested a review from a team as a code owner September 3, 2026 22:00
@github-actions github-actions Bot added the changelog:repository Changes to the repository not within any gem label Sep 3, 2026
@codecov

codecov Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.26%. Comparing base (ebfaca3) to head (fb913b0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6578   +/-   ##
=======================================
  Coverage   92.26%   92.26%           
=======================================
  Files        1037     1037           
  Lines       21228    21228           
=======================================
  Hits        19586    19586           
  Misses       1642     1642           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tvdeyen tvdeyen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:repository Changes to the repository not within any gem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants