[v4.5] Remove adjustments from cart orders when promotion is discarded - #6563
Open
mamhoff wants to merge 2 commits into
Open
[v4.5] Remove adjustments from cart orders when promotion is discarded#6563mamhoff wants to merge 2 commits into
mamhoff wants to merge 2 commits into
Conversation
Benefits need access to their promotion even when it's discarded to properly handle cleanup and checks. This matches the pattern used in OrderPromotion and PromotionCode associations. (cherry picked from commit d57b042) # Conflicts: # promotions/app/models/solidus_promotions/benefit.rb # promotions/spec/models/spree/line_item_spec.rb
(cherry picked from commit 8c3c033)
mamhoff
added
backport-v4.5
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
maintov4.5:Questions ?
Please refer to the Backport tool documentation