Skip to content

[v4.7] Remove adjustments from cart orders when promotion is discarded - #6561

Merged
mamhoff merged 2 commits into
v4.7from
backport/v4.7/pr-6557
Aug 28, 2026
Merged

[v4.7] Remove adjustments from cart orders when promotion is discarded#6561
mamhoff merged 2 commits into
v4.7from
backport/v4.7/pr-6557

Conversation

@solidus-bot

@solidus-bot solidus-bot Bot commented Aug 28, 2026

Copy link
Copy Markdown

Backport

This will backport the following commits from main to v4.7:

Questions ?

Please refer to the Backport tool documentation

Benefits need access to their promotion even when it's discarded to
properly handle cleanup and checks. This matches the pattern used in
OrderPromotion and PromotionCode associations.

(cherry picked from commit d57b042)
@solidus-bot
solidus-bot Bot requested a review from a team as a code owner August 28, 2026 00:19
@solidus-bot solidus-bot Bot added the changelog:solidus_promotions Changes to the solidus_promotions gem label Aug 28, 2026
@codecov

codecov Bot commented Aug 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.16%. Comparing base (aa09a7d) to head (275d444).
⚠️ Report is 1 commits behind head on v4.7.

Additional details and impacted files
@@           Coverage Diff           @@
##             v4.7    #6561   +/-   ##
=======================================
  Coverage   92.16%   92.16%           
=======================================
  Files         991      991           
  Lines       20299    20300    +1     
=======================================
+ Hits        18708    18709    +1     
  Misses       1591     1591           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mamhoff
mamhoff merged commit f65c52f into v4.7 Aug 28, 2026
39 checks passed
@mamhoff
mamhoff deleted the backport/v4.7/pr-6557 branch August 28, 2026 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:solidus_promotions Changes to the solidus_promotions gem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants