Move line_item_comparison_hooks config to Spree::Config #6050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting line item comparison hooks in a `config.to_prepare` block will currently autoload the Spree::Order model (and subsequently any model referenced in that class definition), slowing down the boot process in development mode (when we want our app/ directory to be autoloaded. This moves setting those hooks to Spree::Config, which is already loaded by the time initializers run. This allows us to move code out of `config.to_prepare` hooks, and stop the order class from being inadvertently eager loaded.
github-actions
bot
added
changelog:solidus_core
tvdeyen
reviewed
Dec 23, 2024
| def line_item_comparison_hooks=(value) | ||
| Spree::Config.line_item_comparison_hooks = value.to_a | ||
| end | ||
| deprecate :line_item_comparison_hooks=, deprecator: Spree.deprecator |
There was a problem hiding this comment.
Can we add a deprecation message?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting line item comparison hooks in a
config.to_prepareblock will currently autoload the Spree::Order model (and subsequently any model referenced in that class definition), slowing down the boot process in development mode (when we want our app/ directory to be autoloaded.This moves setting those hooks to Spree::Config, which is already loaded by the time initializers run. This allows us to move code out of
config.to_preparehooks, and stop the order class from being inadvertently eager loaded.Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: