Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Give even more dialogs more time to open in tests #6017

Merged

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Dec 6, 2024

These dialog tests fail often. We should give them more time to open.

@tvdeyen tvdeyen requested a review from a team as a code owner December 6, 2024 11:50
@tvdeyen tvdeyen requested review from MadelineCollier and removed request for a team December 6, 2024 11:50
@tvdeyen tvdeyen enabled auto-merge December 6, 2024 11:50
@tvdeyen tvdeyen added backport-v4.2 Backport this pull-request to v4.2 backport-v4.3 Backport this pull-request to v4.3 backport-v4.4 Backport this pull-request to v4.4 labels Dec 6, 2024
Copy link
Contributor

@MadelineCollier MadelineCollier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty annoying we have to do this, just reinforces the reasoning behind getting the admin spec functional without JS like you have been pushing for.

These dialog tests fail often. We should give them more
time to open.
@tvdeyen tvdeyen force-pushed the give-more-dialogs-more-time-to-open0in-specs branch from 0ab637f to 8d6f016 Compare December 6, 2024 11:55
@tvdeyen tvdeyen merged commit b0bf8f4 into solidusio:main Dec 6, 2024
13 of 14 checks passed
@tvdeyen tvdeyen deleted the give-more-dialogs-more-time-to-open0in-specs branch December 6, 2024 12:17
Copy link

github-actions bot commented Dec 6, 2024

💔 Some backports could not be created

Status Branch Result
v4.2 Backport failed because of merge conflicts

You might need to backport the following PRs to v4.2:
- Merge pull request #5596 from softr8/backend_order_email
- Merge pull request #5999 from mamhoff/easier-user-class-handle
- Merge pull request #5993 from tvdeyen/harden-admin-feature-specs
- test: Do not wait 30 seconds for a test to fail
- test: Wait for modal to open before testing its content
- Merge pull request #5979 from mamhoff/fix-missing-translation-spec
- Merge pull request #5956 from mamhoff/allow-passing-in-user-class
- Merge pull request #5954 from SuperGoodSoft/fix/new-rubocop-rules
v4.3 Backport failed because of merge conflicts

You might need to backport the following PRs to v4.3:
- tests: Give dialogs a little more time to open
- test: Wait for modal to open before testing its content
v4.4

Manual backport

To create the backport manually run:

backport --pr 6017

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v4.2 Backport this pull-request to v4.2 backport-v4.3 Backport this pull-request to v4.3 backport-v4.4 Backport this pull-request to v4.4 changelog:solidus_admin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants