-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add can apply to promotions #6013
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌 everything here makes sense, thanks.
None of this works right now, but let's write a spec that details how things should work.
The promotion class should decide whether it can apply.
This duplicated the logic from SolidusPromotions::Promotion.order_activatable, and this way it reads nicer.
9a9509d
to
3588c15
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6013 +/- ##
==========================================
+ Coverage 87.81% 89.46% +1.64%
==========================================
Files 476 782 +306
Lines 11658 18009 +6351
==========================================
+ Hits 10238 16112 +5874
- Misses 1420 1897 +477 ☔ View full report in Codecov by Sentry. |
Not sure what happened to the Backport PR? I don't see it? |
I tried to retrigger the flow but it's still skipping it. I don't think we changed anything there recently, so it might a temporary issue with GitHub Actions. |
Should be fixed by #6016 |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Summary
This fixes the orders/adjustment pages when using the new promotion system.
Bug report from @boomer196 on Slack: