[specs] Wait for modal before testing its content #5998
Conversation
Building off of solidusio#5993, a few more specs required a short wait time to give the modal a chance to load. They were flaky (failing somewhat regularly in CI, but always passing locally) and this should help remedy that.
MadelineCollier
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5998 +/- ##
=======================================
Coverage 89.46% 89.46%
=======================================
Files 782 782
Lines 17999 17999
=======================================
Hits 16102 16102
Misses 1897 1897 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Just to clarify: Capybara already waits 2 seconds by default. This change "just" raises the wait time to 5 seconds. We should reflect that in the commit message (and PR description) so that we do not give the impression to contributors that waiting was disabled. This is ok for now, but also slows down the test suite in case of an error in the implementation.
The actual underlying issue is that we need to use a fully JS enabled browser to test simple CRUD actions in the new admin. This can only be solved by fixing the implementation (see #5945 for background) or by not writing those UX tests. They are not very valuable, as they do not test business logic, but the questionable UX of the new admin.
Fair points! |
Ah, dang. The commit message has not been changed, right? |
|
Oh apologies I updated the PR description but forgot to edit the commit |
|
No worries :) |
tvdeyen
added
backport-v4.1
💔 Some backports could not be created
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
💔 Some backports could not be created
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
💔 Some backports could not be created
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
tvdeyen
removed
backport-v4.1
Building off of #5993, a few more specs required a short wait time to give the modal a chance to load. Capybara waits for 2 seconds by default but this raises the wait to 5 seconds. They were flaky (failing somewhat regularly in CI, but always passing locally) and this should help remedy that.